Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reworks the preset system with two key changes: fixing the mute preset to use the correct dropdown option for toggle behavior, and converting preset text from static strings with variable interpolation to JavaScript expressions for dynamic text display.
Changes:
- Fixed mute preset action to use toggle option (-1) instead of fixed value (2)
- Converted preset button text to JavaScript expressions with fallback logic
- Added
textExpression: trueflag to enable expression evaluation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
change: preset names are now expressions
janikwitzig
force-pushed
the
183-preset-rework
branch
from
e0fb816 to
8b24b33
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: mute preset now uses correct dropdown option
change: preset names are now expressions