Add some web app URL and type feedback and variables#68
Draft
peternewman wants to merge 5 commits intobitfocus:masterfrom
Draft
Add some web app URL and type feedback and variables#68peternewman wants to merge 5 commits intobitfocus:masterfrom
peternewman wants to merge 5 commits intobitfocus:masterfrom
Conversation
Contributor
|
Since app type and app value do not persist as state values on the device, I believe it would not be appropriate to store them as variables on the companion module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65
Wants @itota to have a look, or pending me getting a chance to test with a suitable TV at some point in the future...