Conversation
`title` props in FontAwesome no longer do anything. (Even though the prop is marked deprecated, it doesn't work at all.) This PR fixes the broken tooltips either as a `title` in a parent element or as `InlineHelp` where more emphasis may be desirable. - `InputFeatureIcons`, and others - In one case (ModuleVersionsRefresh) local rabbit insisted on a slightly bigger change to put the icon in the tab order.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRefactors UI help/tooltip rendering: replaces Changes
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
webui/src/Modules/ModuleVersionUsageIcon.tsx (1)
19-23: Consider handling singular vs. plural grammar for better polish.When
matchingConnectionsis exactly 1, the text will read "1 connections are using this version" which is grammatically awkward. A small improvement could be:✏️ Optional grammar fix
- <InlineHelp help={`${matchingConnections} connections are using this version`}> + <InlineHelp help={`${matchingConnections} connection${matchingConnections === 1 ? ' is' : 's are'} using this version`}> <FontAwesomeIcon icon={isInstalled ? faPlug : faWarning} - aria-label={`${matchingConnections} connections are using this version`} + aria-label={`${matchingConnections} connection${matchingConnections === 1 ? ' is' : 's are'} using this version`} />Totally optional—the tooltip fix itself looks great!
webui/src/Instances/ModuleVersionsRefresh.tsx (1)
31-42: Great accessibility improvements! 🎉Adding keyboard support with
role="button"andtabIndex={0}is a nice enhancement beyond just fixing the tooltip. One small suggestion: when handling the space key on a button-role element, it's good practice to prevent the default scroll behavior.🛡️ Prevent page scroll on space key
onKeyDown={(e) => { - if (e.key === 'Enter' || e.key === ' ') doRefreshModules() + if (e.key === 'Enter' || e.key === ' ') { + e.preventDefault() + doRefreshModules() + } }}Otherwise, pressing space might scroll the page while also triggering the refresh action.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 57b632ce-ac08-40ef-93a4-8f7127130a51
📒 Files selected for processing (6)
webui/src/Controls/OptionsInputField.tsxwebui/src/Instances/AddInstancePanel.tsxwebui/src/Instances/ModuleVersionsRefresh.tsxwebui/src/Instances/UpdateInstanceToLatestBadge.tsxwebui/src/Modules/ModuleVersionUsageIcon.tsxwebui/src/Modules/ModulesList.tsx
titleprops in FontAwesome no longer do anything. (Even though the prop is marked deprecated, it doesn't work at all.) This PR fixes the broken tooltips either as atitlein a parent element or asInlineHelpwhere more emphasis may be desirable.InputFeatureIcons(the $ and 🌐 indicators on inputs)Summary by CodeRabbit