Skip to content

Comments

Add new Icon parameter to BitCircularTimePicker (#12080)#12081

Merged
msynk merged 1 commit intobitfoundation:developfrom
msynk:12080-blazorui-circulartimepicker-new-icon
Feb 13, 2026
Merged

Add new Icon parameter to BitCircularTimePicker (#12080)#12081
msynk merged 1 commit intobitfoundation:developfrom
msynk:12080-blazorui-circulartimepicker-new-icon

Conversation

@msynk
Copy link
Member

@msynk msynk commented Feb 13, 2026

closes #12080

Summary by CodeRabbit

  • New Features

    • Added icon customization parameters to the Circular Time Picker component, enabling users to customize both the main icon and close button icon independently.
    • Introduced support for external icon libraries (FontAwesome, Bootstrap Icons) alongside built-in icons, with clear precedence rules for icon selection.
  • Documentation

    • Enhanced demo documentation with examples showing how to integrate and use external icon libraries with the Circular Time Picker component.

@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

Walkthrough

The changes enable external icon library support in the BitCircularTimePicker component by introducing new BitIconInfo and icon name parameters, refactoring icon rendering to dynamically compute CSS classes via BitIconInfo.From() and GetCssClasses(), and expanding demo examples to showcase FontAwesome and Bootstrap Icons integration.

Changes

Cohort / File(s) Summary
Core Component Implementation
src/BlazorUI/Bit.BlazorUI/Components/Inputs/CircularTimePicker/BitCircularTimePicker.razor, BitCircularTimePicker.razor.cs
Added four new public parameters (Icon, IconName, CloseButtonIcon, CloseButtonIconName) for icon customization; refactored icon rendering in markup to dynamically compute CSS classes using BitIconInfo.From() and GetCssClasses() instead of static class strings; made IconName nullable and removed its default value to support external icon precedence.
Demo and Sample Updates
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/CircularTimePicker/BitCircularTimePickerDemo.razor, BitCircularTimePickerDemo.razor.cs, BitCircularTimePickerDemo.razor.samples.cs
Replaced "Style & Class" demo with new "External Icons" demo showcasing FontAwesome and Bootstrap Icons via CDN; added new icon customization parameters to demo component; introduced sample code blocks demonstrating external icon library usage; updated example field numbering (example12 → example13 → example14) to reflect restructured demo organization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 hops with delight
External icons now flutter free,
FontAwesome and Bootstrap, come joyfully!
The TimePicker spins with dynamic grace,
Each icon finds its rightful place! ✨⏰

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding a new Icon parameter to BitCircularTimePicker.
Linked Issues check ✅ Passed The pull request implements the new Icon parameter to enable external icons in BitCircularTimePicker, directly addressing issue #12080.
Out of Scope Changes check ✅ Passed All changes are directly related to implementing the new Icon parameter and supporting external icons as specified in issue #12080.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@msynk msynk merged commit 938c99c into bitfoundation:develop Feb 13, 2026
3 checks passed
@msynk msynk deleted the 12080-blazorui-circulartimepicker-new-icon branch February 13, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The new Icon implementation for the BitCircularTimePicker component

1 participant