Skip to content

Comments

Add new Icon parameter to BitDateRangePicker (#12084)#12085

Merged
msynk merged 1 commit intobitfoundation:developfrom
msynk:12084-blazorui-datarangepicker-new-icon
Feb 13, 2026
Merged

Add new Icon parameter to BitDateRangePicker (#12084)#12085
msynk merged 1 commit intobitfoundation:developfrom
msynk:12084-blazorui-datarangepicker-new-icon

Conversation

@msynk
Copy link
Member

@msynk msynk commented Feb 13, 2026

closes #12084

Summary by CodeRabbit

  • New Features

    • Added support for external icon libraries (FontAwesome, Bootstrap Icons) in DateRangePicker via new Icon parameter.
    • Icon parameter takes precedence over IconName when both are specified.
  • Documentation

    • Added demo examples showing external icon library integration with DateRangePicker.
  • Chores

    • Removed BOM characters from component files.

@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

Walkthrough

This pull request adds support for external icon libraries to the BitDateRangePicker component by introducing a new public Icon parameter of type BitIconInfo?. The parameter accepts icon information from external libraries, with fallback to the built-in IconName parameter. Demo files and documentation are updated to showcase FontAwesome and Bootstrap icon usage.

Changes

Cohort / File(s) Summary
Icon Parameter Addition
src/BlazorUI/Bit.BlazorUI/Components/Inputs/DateRangePicker/BitDateRangePicker.razor.cs, src/BlazorUI/Bit.BlazorUI/Components/Inputs/DateRangePicker/BitDateRangePicker.razor
Added new BitIconInfo? Icon parameter to component. Updated icon rendering to use BitIconInfo.From() for dynamic icon resolution. Removed BOM character from file header.
Demo Documentation Updates
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/DateRangePicker/BitDateRangePickerDemo.razor.cs, src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/DateRangePicker/BitDateRangePickerDemo.razor, src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/DateRangePicker/BitDateRangePickerDemo.razor.samples.cs
Replaced "Style & Class" demo block with "External Icons" demo showcasing FontAwesome and Bootstrap icon usage. Updated parameter documentation, converted collection initializers to array syntax, and reorganized demo examples with updated references.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A picker of dates now sees far and wide,
With icons from libraries—a colorful guide!
Bootstrap and FontAwesome join the delight,
External icons sparkle, a feature so bright! ✨

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a new Icon parameter to BitDateRangePicker, which is the primary objective of the pull request.
Linked Issues check ✅ Passed The pull request successfully implements the Icon mechanism for BitDateRangePicker [#12084], enabling external icon support through the new Icon parameter and documentation updates.
Out of Scope Changes check ✅ Passed All changes are directly related to implementing the new Icon parameter for BitDateRangePicker; minor cleanup like BOM removal is incidental to the main objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
38.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@msynk msynk merged commit 23cf7fe into bitfoundation:develop Feb 13, 2026
3 of 4 checks passed
@msynk msynk deleted the 12084-blazorui-datarangepicker-new-icon branch February 13, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The new Icon implementation for the BitDateRangePicker component

1 participant