Prerelease v-10.4.3-pre-01 (#12115)#12150
Merged
msynk merged 5 commits intobitfoundation:developfrom Mar 8, 2026
Merged
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis pull request systematically updates version numbers from 10.4.2 to 10.4.3-pre-01 across the entire codebase. Updates span NuGet package references in project files, global version strings in JavaScript/TypeScript source files, version comments in service workers, template headers, build configuration files, and related documentation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/Templates/Boilerplate/Bit.Boilerplate/.docs/19- Project Miscellaneous Files.md (1)
244-250:⚠️ Potential issue | 🟡 MinorRefresh the rest of this example block.
The snippet now shows current
Bit.*prerelease numbers beside older versions for the surrounding packages, so it no longer mirrors theDirectory.Packages.propsfile it is describing.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Templates/Boilerplate/Bit.Boilerplate/.docs/19-` Project Miscellaneous Files.md around lines 244 - 250, The example XML block is out of sync with Directory.Packages.props—update the PackageVersion entries (e.g., PackageVersion Include="Bit.BlazorUI", "Bit.Butil", "Microsoft.AspNetCore.Components.WebAssembly", "Microsoft.EntityFrameworkCore.SqlServer", "Hangfire.AspNetCore", "Riok.Mapperly") so their Version attributes exactly match the current values in Directory.Packages.props (including the Bit.* prerelease suffixes) and refresh the surrounding lines in the block so the entire snippet mirrors Directory.Packages.props consistently.
🧹 Nitpick comments (2)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (1)
5-13: Consider a shared property for the internal package version.These
Bit.*entries move in lockstep every prerelease. A single property here would reduce churn and make future version bumps less error-prone.♻️ Possible cleanup
<Project> + <PropertyGroup> + <BitPackagesVersion>10.4.3-pre-01</BitPackagesVersion> + </PropertyGroup> <ItemGroup> - <PackageVersion Include="Bit.Butil" Version="10.4.3-pre-01" /> - <PackageVersion Include="Bit.BlazorUI" Version="10.4.3-pre-01" /> - <PackageVersion Include="Bit.BlazorES2019" Version="10.4.3-pre-01" /> - <PackageVersion Include="Bit.BlazorUI.Icons" Version="10.4.3-pre-01" /> - <PackageVersion Include="Bit.BlazorUI.Assets" Version="10.4.3-pre-01" /> - <PackageVersion Include="Bit.BlazorUI.Extras" Version="10.4.3-pre-01" /> - <PackageVersion Include="Bit.Bswup" Version="10.4.3-pre-01" /> - <PackageVersion Include="Bit.CodeAnalyzers" Version="10.4.3-pre-01" /> - <PackageVersion Include="Bit.SourceGenerators" Version="10.4.3-pre-01" /> + <PackageVersion Include="Bit.Butil" Version="$(BitPackagesVersion)" /> + <PackageVersion Include="Bit.BlazorUI" Version="$(BitPackagesVersion)" /> + <PackageVersion Include="Bit.BlazorES2019" Version="$(BitPackagesVersion)" /> + <PackageVersion Include="Bit.BlazorUI.Icons" Version="$(BitPackagesVersion)" /> + <PackageVersion Include="Bit.BlazorUI.Assets" Version="$(BitPackagesVersion)" /> + <PackageVersion Include="Bit.BlazorUI.Extras" Version="$(BitPackagesVersion)" /> + <PackageVersion Include="Bit.Bswup" Version="$(BitPackagesVersion)" /> + <PackageVersion Include="Bit.CodeAnalyzers" Version="$(BitPackagesVersion)" /> + <PackageVersion Include="Bit.SourceGenerators" Version="$(BitPackagesVersion)" /> ... - <PackageVersion Condition=" '$(offlineDb)' == 'true' OR '$(offlineDb)' == ''" Include="Bit.Besql" Version="10.4.3-pre-01" /> + <PackageVersion Condition=" '$(offlineDb)' == 'true' OR '$(offlineDb)' == ''" Include="Bit.Besql" Version="$(BitPackagesVersion)" />Also applies to: 93-93
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props` around lines 5 - 13, Introduce a single shared property for the prerelease version and reference it from each Bit.* PackageVersion entry: add a property (e.g. BitPrereleaseVersion with value 10.4.3-pre-01) near the top of Directory.Packages.props and replace the literal Version="10.4.3-pre-01" values on the PackageVersion elements (e.g. PackageVersion Include="Bit.Butil", PackageVersion Include="Bit.BlazorUI", PackageVersion Include="Bit.BlazorES2019", etc.) with Version="$(BitPrereleaseVersion)"; also apply the same replacement to the other Bit.* PackageVersion occurrences mentioned in the review so all Bit packages share the single property.src/BlazorES2019/Bit.BlazorES2019/buildTransitive/Bit.BlazorES2019.targets (1)
3-10: Use version-independent paths in the targets file to eliminate release-time maintenance.The hard-coded version
10.4.3-pre-01and package name require manual updates on every release. SincecontentFilesandbuildTransitiveare siblings in the NuGet package structure, resolving from$(MSBuildThisFileDirectory)..\contentFilesremoves that coupling:♻️ Suggested refactor
- <Content Remove="$(NuGetPackageRoot)/bit.blazores2019/10.4.3-pre-01/contentFiles/any/net9.0/wwwroot/_framework/*.js" Condition="$(TargetFramework.Contains('net9.0'))" /> - <Content Include="$(NuGetPackageRoot)/bit.blazores2019/10.4.3-pre-01/contentFiles/any/net9.0/wwwroot/_framework/*.js" Condition="$(TargetFramework.Contains('net9.0'))"> + <Content Remove="$(MSBuildThisFileDirectory)..\contentFiles\any\net9.0\wwwroot\_framework\*.js" Condition="$(TargetFramework.Contains('net9.0'))" /> + <Content Include="$(MSBuildThisFileDirectory)..\contentFiles\any\net9.0\wwwroot\_framework\*.js" Condition="$(TargetFramework.Contains('net9.0'))"> <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> <CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory> <Link>wwwroot\_framework\%(Filename)%(Extension)</Link> </Content> - <Content Remove="$(NuGetPackageRoot)/bit.blazores2019/10.4.3-pre-01/contentFiles/any/net10.0/wwwroot/_framework/*.js" Condition="$(TargetFramework.Contains('net10.0'))" /> - <Content Include="$(NuGetPackageRoot)/bit.blazores2019/10.4.3-pre-01/contentFiles/any/net10.0/wwwroot/_framework/*.js" Condition="$(TargetFramework.Contains('net10.0'))"> + <Content Remove="$(MSBuildThisFileDirectory)..\contentFiles\any\net10.0\wwwroot\_framework\*.js" Condition="$(TargetFramework.Contains('net10.0'))" /> + <Content Include="$(MSBuildThisFileDirectory)..\contentFiles\any\net10.0\wwwroot\_framework\*.js" Condition="$(TargetFramework.Contains('net10.0'))"> <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> <CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory> <Link>wwwroot\_framework\%(Filename)%(Extension)</Link> </Content>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/BlazorES2019/Bit.BlazorES2019/buildTransitive/Bit.BlazorES2019.targets` around lines 3 - 10, Replace the hard-coded package/version paths in the Content Include/Remove entries (the lines containing "$(NuGetPackageRoot)/bit.blazores2019/10.4.3-pre-01/contentFiles/…") with a version-independent resolution that navigates from the current targets file directory (use $(MSBuildThisFileDirectory)..\contentFiles or equivalent) so the buildTransitive targets reference the sibling contentFiles folder instead of a specific package/version; update the Content Include and Content Remove elements shown in the diff to compute the path from MSBuildThisFileDirectory rather than embedding "bit.blazores2019/10.4.3-pre-01".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Templates/Boilerplate/Bit.Boilerplate/README.md`:
- Line 5: Fix the README generation sentence in README.md by inserting the
missing word "was" so the sentence reads "This project was generated by bit-bp
template v-10.4.3-pre-01 using the following command:"; update the template or
generator output that produces the line "This project generated by bit-bp
template v-10.4.3-pre-01 using the following command:" to include "was" in the
generated string.
---
Outside diff comments:
In `@src/Templates/Boilerplate/Bit.Boilerplate/.docs/19-` Project Miscellaneous
Files.md:
- Around line 244-250: The example XML block is out of sync with
Directory.Packages.props—update the PackageVersion entries (e.g., PackageVersion
Include="Bit.BlazorUI", "Bit.Butil",
"Microsoft.AspNetCore.Components.WebAssembly",
"Microsoft.EntityFrameworkCore.SqlServer", "Hangfire.AspNetCore",
"Riok.Mapperly") so their Version attributes exactly match the current values in
Directory.Packages.props (including the Bit.* prerelease suffixes) and refresh
the surrounding lines in the block so the entire snippet mirrors
Directory.Packages.props consistently.
---
Nitpick comments:
In `@src/BlazorES2019/Bit.BlazorES2019/buildTransitive/Bit.BlazorES2019.targets`:
- Around line 3-10: Replace the hard-coded package/version paths in the Content
Include/Remove entries (the lines containing
"$(NuGetPackageRoot)/bit.blazores2019/10.4.3-pre-01/contentFiles/…") with a
version-independent resolution that navigates from the current targets file
directory (use $(MSBuildThisFileDirectory)..\contentFiles or equivalent) so the
buildTransitive targets reference the sibling contentFiles folder instead of a
specific package/version; update the Content Include and Content Remove elements
shown in the diff to compute the path from MSBuildThisFileDirectory rather than
embedding "bit.blazores2019/10.4.3-pre-01".
In `@src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props`:
- Around line 5-13: Introduce a single shared property for the prerelease
version and reference it from each Bit.* PackageVersion entry: add a property
(e.g. BitPrereleaseVersion with value 10.4.3-pre-01) near the top of
Directory.Packages.props and replace the literal Version="10.4.3-pre-01" values
on the PackageVersion elements (e.g. PackageVersion Include="Bit.Butil",
PackageVersion Include="Bit.BlazorUI", PackageVersion
Include="Bit.BlazorES2019", etc.) with Version="$(BitPrereleaseVersion)"; also
apply the same replacement to the other Bit.* PackageVersion occurrences
mentioned in the review so all Bit packages share the single property.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ea74cd3f-80b5-49e2-957f-48f2483824b7
📒 Files selected for processing (47)
src/Besql/Bit.Besql/wwwroot/bit-besql.jssrc/Bit.Build.propssrc/BlazorES2019/Bit.BlazorES2019/buildTransitive/Bit.BlazorES2019.targetssrc/BlazorUI/Bit.BlazorUI/Info.cssrc/BlazorUI/Bit.BlazorUI/Scripts/general.tssrc/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csprojsrc/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csprojsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csprojsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csprojsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csprojsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.jssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csprojsrc/BlazorUI/Demo/Directory.Build.propssrc/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.jssrc/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.jssrc/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.jssrc/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.jssrc/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.tssrc/Bswup/Bit.Bswup/Scripts/bit-bswup.sw-cleanup.tssrc/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.tssrc/Bswup/Bit.Bswup/Scripts/bit-bswup.tssrc/Bswup/FullDemo/Client/wwwroot/service-worker.jssrc/Bswup/FullDemo/Client/wwwroot/service-worker.published.jssrc/Butil/Bit.Butil/Scripts/butil.tssrc/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csprojsrc/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csprojsrc/Templates/Boilerplate/Bit.Boilerplate/.docs/19- Project Miscellaneous Files.mdsrc/Templates/Boilerplate/Bit.Boilerplate/README.mdsrc/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.jssrc/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.propssrc/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csprojsrc/Websites/Careers/src/Bit.Websites.Careers.Client/wwwroot/service-worker.published.jssrc/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csprojsrc/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csprojsrc/Websites/Careers/src/Directory.Build.propssrc/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csprojsrc/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razorsrc/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cssrc/Websites/Platform/src/Bit.Websites.Platform.Client/wwwroot/service-worker.published.jssrc/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csprojsrc/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csprojsrc/Websites/Platform/src/Directory.Build.propssrc/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csprojsrc/Websites/Sales/src/Bit.Websites.Sales.Client/wwwroot/service-worker.published.jssrc/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csprojsrc/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csprojsrc/Websites/Sales/src/Directory.Build.props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12115
Summary by CodeRabbit