Skip to content

fix compilation error with later 3.0.x versions of arduino-esp32 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jscrane
Copy link

@jscrane jscrane commented Jan 12, 2025

This fixes a compilation error in VGA.h:

/home/steve/Arduino/libraries/ESP32Lib/src/VGA/VGA.h: In member function 'virtual bool VGA::init(const Mode&, const int*, int, int)':
/home/steve/Arduino/libraries/ESP32Lib/src/VGA/VGA.h:36:10: error: no return statement in function returning non-void [-Werror=return-type]
   36 |         {}

It looks as if this became an error sometime between version 3.0.3 and 3.0.7.

I'm also getting a lot of compiler warnings. I can have a go at fixing these as well if you'd like?

Cheers,
Steve

@jscrane
Copy link
Author

jscrane commented Jan 12, 2025

The second commit addresses a probable bug which would have always caused a buffer allocation.

@otiskujawa
Copy link

otiskujawa commented Mar 20, 2025

Thanks
This fixes #98 and #97 therefore making 4.0 usable again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants