-
Notifications
You must be signed in to change notification settings - Fork 23
Support Auction Swaps #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
04c6957
refactor: add strategy swaps
crisdut e36e6cd
feat: add auction tests
crisdut e2f89a7
refactor: add next offer
crisdut 65d1b29
fix: offer/bid id generation
crisdut ce2700c
chore: lint
crisdut 34f062a
refactor: fix
crisdut cab42f7
Merge remote-tracking branch 'origin/development' into CD/seq
josediegorobles 1282b69
Merge remote-tracking branch 'origin/development' into CD/seq
josediegorobles 971bd3a
fix: add next offer as public offer
crisdut b2a88db
fix: avoid dust transactions
crisdut a42700d
Update struts in typescript (#436)
josediegorobles 3202f6c
Merge branch 'development' into CD/seq
josediegorobles e036ff7
test: add sign hash tests
crisdut 007eb6b
refactor: auctions swaps
crisdut cb14cd0
Merge branch 'CD/seq' of github.com:diba-io/bitmask-core into CD/seq
crisdut 60c67f0
feat: add auction result
crisdut 97c8423
chore: comment metrics
crisdut 7e58a09
Modifs in typescript (#441)
josediegorobles 08b5806
Merge remote-tracking branch 'origin/development' into CD/seq
josediegorobles ddf3efa
feat: support to airdrops
crisdut 2e5a3d8
fix: airdrop fifo
crisdut 0b5a312
test: finish wasm use cases
crisdut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to abstract this out so it's not in
src/carbonado.rsmethods? Ideally this file would be cleaner and simpler, more focused and have less duplication.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so, but I feel like it will lose some of its purpose. I centralized in this file all the calls that are sometimes made by the client and sometimes made by the server.
But yes, I can carry out another separation.