Feature/new example encoding hlsv3 with aes#50
Open
Conversation
jamescyeh
approved these changes
Jul 30, 2018
Contributor
jamescyeh
left a comment
jamescyeh
left a comment
There was a problem hiding this comment.
just two minor things, but lgtm
|
|
||
| // AES - Configuration | ||
| AesEncryptionDrm aesEncryptionDrm = new AesEncryptionDrm(); | ||
| aesEncryptionDrm.setKey("<SET_YOUR_STRING_KEY>"); // 128 bit (16 bytes) ex.: cab5b529ae28d5cc5e3e7bc3fd4a544d |
Contributor
There was a problem hiding this comment.
Maybe let's have this info as a const (err I mean static) at the top of the file, but it's a minor quibble.
| // AES - Configuration | ||
| AesEncryptionDrm aesEncryptionDrm = new AesEncryptionDrm(); | ||
| aesEncryptionDrm.setKey("<SET_YOUR_STRING_KEY>"); // 128 bit (16 bytes) ex.: cab5b529ae28d5cc5e3e7bc3fd4a544d | ||
| aesEncryptionDrm.setIv("<SET_YOUR_STRING_IV>"); // 128 bit (16 bytes) ex.: 08eecef4b026deec395234d94218273d |
gfronza
suggested changes
Jul 31, 2018
Contributor
gfronza
left a comment
gfronza
left a comment
There was a problem hiding this comment.
only two minor code styling remarks.
|
|
||
| // Encoding Configuration - Adding h264 Representations | ||
| List<H264Representation> h264Representations = new ArrayList<>(); | ||
| h264Representations.add ( new H264Representation(null, 240, null, 400L, ProfileH264.HIGH)); |
Contributor
There was a problem hiding this comment.
Remove the whitespace between ( and new).
| aacConfiguration.setRate(48000f); | ||
| aacConfiguration = bitmovinApi.configuration.audioAAC.create(aacConfiguration); | ||
|
|
||
| for (H264Representation representation : h264Representations) { |
Contributor
There was a problem hiding this comment.
the { goes to the next line.
rkersche
suggested changes
Aug 1, 2018
| inputStreamVideo.setSelectionMode(StreamSelectionMode.AUTO); | ||
| inputStreamVideo.setPosition(0); | ||
|
|
||
| Stream audioStream = new Stream(); |
There was a problem hiding this comment.
Audio stream doesn't need to be added for every representation. It's sufficient to do it once.
rkersche
suggested changes
Aug 8, 2018
|
|
||
| // Encoding Configuration - Adding h264 Representations | ||
| List<H264Representation> h264Representations = new ArrayList<>(); | ||
| h264Representations.add (new H264Representation(null, 240, null, 400L, ProfileH264.HIGH)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.