[bitnami/redis-sentinel] Allow setting tls-ca-cert-dir via ENV variable#79386
Merged
migruiz4 merged 2 commits intobitnami:mainfrom Apr 11, 2025
Merged
[bitnami/redis-sentinel] Allow setting tls-ca-cert-dir via ENV variable#79386migruiz4 merged 2 commits intobitnami:mainfrom
migruiz4 merged 2 commits intobitnami:mainfrom
Conversation
Similar to how it's done in bitnami/redis. Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
javsalgar
added
verify
migruiz4
reviewed
Apr 8, 2025
Member
migruiz4
left a comment
migruiz4
left a comment
There was a problem hiding this comment.
Hi @mueller-ma , thank you very much for your contribution!
Could you please take a look at my comment?
bitnami/redis-sentinel/7.4/debian-12/rootfs/opt/bitnami/scripts/libredissentinel.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
mueller-ma
force-pushed
the
feat/redis-sentinel-ca-dir
branch
from
707b514 to
7acdd45
Compare
migruiz4
approved these changes
Apr 11, 2025
Member
migruiz4
left a comment
migruiz4
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution @mueller-ma, looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Allow configuration of
tls-ca-cert-dir, similar to how it's done in bitnami/redis.Benefits
It allows setting a directory container CA certificates, so all CAs on the Docker host can be trusted. No need to configure a single trusted ca.
Possible drawbacks
None
Applicable issues
None
Additional information