[bitnami/influxdb] add config file format support / issue 79984#79986
[bitnami/influxdb] add config file format support / issue 79984#79986juan131 merged 5 commits intobitnami:mainfrom
Conversation
kizuna-lek
force-pushed
the
support/issue-79984
branch
from
46ac087 to
4d69e61
Compare
javsalgar
added
verify
juan131
left a comment
juan131
left a comment
There was a problem hiding this comment.
Hi @kizuna-lek
Thanks so much for this great initiative! Please check my comments
| case "${INFLUXDB_CONF_FILE_FORMAT}" in | ||
| yaml|yml|toml|json) | ||
| # Legal format | ||
| ;; | ||
| *) | ||
| error "Unsupported config file format: ${INFLUXDB_CONF_FILE_FORMAT}" | ||
| exit 1 | ||
| ;; | ||
| esac |
There was a problem hiding this comment.
Please move this validation to influxdb_validate instead:
There was a problem hiding this comment.
Also: please double-check whether exiting references at libinfluxdb.sh to INFLUXDB_CONF_FILE need to be adapted.
There was a problem hiding this comment.
thk for pointing that, I will revise the validation as suggested.
There was a problem hiding this comment.
INFLUXDB_CONF_FILE is referenced in only 4 places in libinfluxdb.sh: twice in logs, once for assigning a value to config_file, and once as a parameter passed to v2-config-path. None of these instances require modification.
Signed-off-by: kizuna-lek <asd98041@qq.com>
Signed-off-by: kizuna-lek <asd98041@qq.com>
Signed-off-by: kizuna-lek <asd98041@qq.com>
kizuna-lek
force-pushed
the
support/issue-79984
branch
from
2e74828 to
29b6200
Compare
Signed-off-by: kizuna-lek <asd98041@qq.com>
juan131
left a comment
juan131
left a comment
There was a problem hiding this comment.
LGTM! Thanks so much for addressing the suggestions.
3 participants
Description of the change
This PR introduces dynamic configuration file format support for InfluxDB containers by:
INFLUXDB_CONF_FILE_FORMATenvironment variable (default:yaml)INFLUXDB_CONF_FILEpath with the specified extension (e.g.config.toml)config.yamlsetupsThe change affects:
libinfluxdb-env.sh(new variable declaration)Benefits
✅ Flexible deployments: Users can now choose between YAML/YML/TOML/JSON formats
✅ Smooth migration: Existing
config.yamlinstallations remain unaffected✅ Explicit control: Clear environment variable override (
INFLUXDB_CONF_FILE_FORMAT)✅ K8s/Helm friendly: Easy integration with Helm charts via
values.yamlPossible drawbacks
Applicable issues