Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,10 @@ Add this to your `.pre-commit-config.yaml`:

## Versions

### 2.8.0

Descriptions now discard only a single whitespace. This way, code blocks can use proper indentation.

### 2.4.0

Add `descriptionStart` and `descriptionEnd` config options (default tags: `@descriptionStart` and `@descriptionEnd`)
Expand Down
2 changes: 1 addition & 1 deletion lib/parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function parseMetadataComments(valuesFilePath, config) {
const paramRegex = new RegExp(`^\\s*${config.comments.format}\\s*${config.tags.param}\\s*([^\\s]+)\\s*(\\[.*?\\])?\\s*(.*)$`);
const sectionRegex = new RegExp(`^\\s*${config.comments.format}\\s*${config.tags.section}\\s*(.*)$`);
const descriptionStartRegex = new RegExp(`^\\s*${config.comments.format}\\s*${config.tags.descriptionStart}\\s*(.*)`);
const descriptionContentRegex = new RegExp(`^\\s*${config.comments.format}\\s*(.*)`);
const descriptionContentRegex = new RegExp(`^\\s*${config.comments.format}\\s?(.*)`);
const descriptionEndRegex = new RegExp(`^\\s*${config.comments.format}\\s*${config.tags.descriptionEnd}\\s*(.*)`);
const skipRegex = new RegExp(`^\\s*${config.comments.format}\\s*${config.tags.skip}\\s*([^\\s]+)\\s*(.*)$`);
const extraRegex = new RegExp(`^\\s*${config.comments.format}\\s*${config.tags.extra}\\s*([^\\s]+)\\s*(\\[.*?\\])?\\s*(.*)$`);
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bitnami/readme-generator-for-helm",
"version": "2.7.0",
"version": "2.8.0",
"description": "Autogenerate READMEs tables and OpenAPI schemas for Helm Charts",
"main": "index.js",
"scripts": {
Expand Down
9 changes: 9 additions & 0 deletions tests/expected-readme.config.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ The command removes all the Kubernetes components associated with the chart and

### Global parameters

Example:

```yaml
global:
imageRegistry: myRegistryName
imagePullSecrets:
- myRegistryKeySecretName
```

| Name | Description | Value |
| ------------------------- | ----------------------------------------------- | ----- |
| `global.imageRegistry` | Global Docker image registry | `""` |
Expand Down
9 changes: 9 additions & 0 deletions tests/expected-readme.first-execution.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@

### Global parameters

Example:

```yaml
global:
imageRegistry: myRegistryName
imagePullSecrets:
- myRegistryKeySecretName
```

| Name | Description | Value |
| ------------------------- | ----------------------------------------------- | ----- |
| `global.imageRegistry` | Global Docker image registry | `""` |
Expand Down
9 changes: 9 additions & 0 deletions tests/expected-readme.last-section-text-below.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ The command removes all the Kubernetes components associated with the chart and

### Global parameters

Example:

```yaml
global:
imageRegistry: myRegistryName
imagePullSecrets:
- myRegistryKeySecretName
```

| Name | Description | Value |
| ------------------------- | ----------------------------------------------- | ----- |
| `global.imageRegistry` | Global Docker image registry | `""` |
Expand Down
9 changes: 9 additions & 0 deletions tests/expected-readme.last-section.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ The command removes all the Kubernetes components associated with the chart and

### Global parameters

Example:

```yaml
global:
imageRegistry: myRegistryName
imagePullSecrets:
- myRegistryKeySecretName
```

| Name | Description | Value |
| ------------------------- | ----------------------------------------------- | ----- |
| `global.imageRegistry` | Global Docker image registry | `""` |
Expand Down
9 changes: 9 additions & 0 deletions tests/expected-readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ The command removes all the Kubernetes components associated with the chart and

### Global parameters

Example:

```yaml
global:
imageRegistry: myRegistryName
imagePullSecrets:
- myRegistryKeySecretName
```

| Name | Description | Value |
| ------------------------- | ----------------------------------------------- | ----- |
| `global.imageRegistry` | Global Docker image registry | `""` |
Expand Down
9 changes: 9 additions & 0 deletions tests/test-readme.config.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ The command removes all the Kubernetes components associated with the chart and

### Global parameters

Example:

```yaml
global:
imageRegistry: myRegistryName
imagePullSecrets:
- myRegistryKeySecretName
```

| Name | Description | Value |
| ------------------------- | ----------------------------------------------- | ----- |
| `global.imageRegistry` | Global Docker image registry | `""` |
Expand Down
9 changes: 9 additions & 0 deletions tests/test-readme.last-section-text-below.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ The command removes all the Kubernetes components associated with the chart and

### Global parameters

Example:

```yaml
global:
imageRegistry: myRegistryName
imagePullSecrets:
- myRegistryKeySecretName
```

| Name | Description | Value |
| ------------------------- | ----------------------------------------------- | ----- |
| `global.imageRegistry` | Global Docker image registry | `""` |
Expand Down
9 changes: 9 additions & 0 deletions tests/test-readme.last-section.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ The command removes all the Kubernetes components associated with the chart and

### Global parameters

Example:

```yaml
global:
imageRegistry: myRegistryName
imagePullSecrets:
- myRegistryKeySecretName
```

| Name | Description | Value |
| ------------------------- | ----------------------------------------------- | ----- |
| `global.imageRegistry` | Global Docker image registry | `""` |
Expand Down
9 changes: 9 additions & 0 deletions tests/test-readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ The command removes all the Kubernetes components associated with the chart and

### Global parameters

Example:

```yaml
global:
imageRegistry: myRegistryName
imagePullSecrets:
- myRegistryKeySecretName
```

| Name | Description | Value |
| ------------------------- | ----------------------------------------------- | ----- |
| `global.imageRegistry` | Global Docker image registry | `""` |
Expand Down
14 changes: 10 additions & 4 deletions tests/test-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,16 @@
## @param global.imageRegistry Global Docker image registry
## @param global.imagePullSecrets Global Docker registry secret names as an array
##
# global:
# imageRegistry: myRegistryName
# imagePullSecrets:
# - myRegistryKeySecretName
## @descriptionStart
## Example:
##
## ```yaml
## global:
## imageRegistry: myRegistryName
## imagePullSecrets:
## - myRegistryKeySecretName
## ```
## @descriptionEnd
global:
imageRegistry: ""
imagePullSecrets: []
Expand Down
Loading