Skip to content

add number modifier to default configuration#99

Closed
pearsonradu wants to merge 1 commit intobitnami:mainfrom
pearsonradu:main
Closed

add number modifier to default configuration#99
pearsonradu wants to merge 1 commit intobitnami:mainfrom
pearsonradu:main

Conversation

@pearsonradu
Copy link
Copy Markdown

Description of the change

Update the default configuration to contain the number modifier. Currently, if you try to add the below sample the generator will fail saying number is an unknown modifier.

YAML

## @param test [string,number] A test value to represent a string or a number
test: ""

Output

Error: Unknown modifier: number for parameter test

Benefits

Allows consumers to use the number modifier without providing a custom configuration.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • [ x ] Version bumped in package.json and package-lock.json according to semver.
  • [ x ] New features are documented in the README.md
  • [ x ] New features contain a new test at the tests folder
  • [ x ] All tests pass running npm test

Signed-off-by: Pearson Radu <62548051+pearsonradu@users.noreply.github.com>
@github-actions github-actions bot requested a review from fmulero March 25, 2024 18:34
@pearsonradu pearsonradu force-pushed the main branch 3 times, most recently from dbf82d8 to 7cb52b1 Compare March 25, 2024 18:39
@pearsonradu
Copy link
Copy Markdown
Author

@fmulero can this be reviewed?

@pearsonradu
Copy link
Copy Markdown
Author

Bump. If this is reviewed I can rebase the changes to fix the merge conflicts.

@github-actions
Copy link
Copy Markdown

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale label Feb 11, 2025
@pearsonradu
Copy link
Copy Markdown
Author

I would still like this to be merged in if possible

@github-actions github-actions bot removed the stale label Feb 12, 2025
@github-actions
Copy link
Copy Markdown

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale label Feb 28, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2025

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@github-actions github-actions bot added the solved label Mar 6, 2025
@bitnami-bot bitnami-bot added stale and removed stale labels Mar 6, 2025
@bitnami-bot bitnami-bot closed this Mar 6, 2025
@hspitzley-czi
Copy link
Copy Markdown

@fmulero any chance of getting eyes on this? I would love to take advantage of this functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants