Make JSON de/serializing of CipherText roundtrip#10
Merged
wraithm merged 1 commit intobitnomial:masterfrom Apr 29, 2025
LaurentRDC:master
Merged
Make JSON de/serializing of CipherText roundtrip#10wraithm merged 1 commit intobitnomial:masterfrom LaurentRDC:master
CipherText roundtrip#10wraithm merged 1 commit intobitnomial:masterfrom
LaurentRDC:master
Conversation
wraithm
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small update to ensure that
CipherTextJSON de/serialization roundtrips.This was tested using a script like so:
{-# LANGUAGE OverloadedStrings #-} import qualified Data.ByteString.Base64 as B64 import Data.Text (Text) import qualified Data.Text.Encoding as TE import Network.VaultTool import Network.VaultTool.Transit main = do let vaultAddress = VaultAddress "..." vaultAuthToken = VaultAuthToken "..." vaultMountedPath = VaultMountedPath "transit" sensitiveInfo = "12345678" :: Text keyname = "..." manager <- defaultManager let conn = authenticatedVaultConnection manager vaultAddress vaultAuthToken CipherText b64 <- encryptBase64 conn vaultMountedPath keyname (encodeBase64 $ TE.encodeUtf8 sensitiveInfo) xs <- either error TE.decodeUtf8Lenient . decodeBase64 <$> decryptBase64 conn vaultMountedPath keyname (CipherText b64) print xs