Skip to content

Makes nonce errors conclusive #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SethMcGuire wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Makes nonce errors conclusive #118

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca72c9d
Makes nonce errors conclusive
SethMcGuire May 1, 2020
82ce2a2
Check if err.message exists before includes
SethMcGuire May 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/eth/EthRpc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,12 @@ class EthRPC {
.sendSignedTransaction(rawTx)
.once('transactionHash', resolve)
.once('error', reject)
.catch(err => reject(err));
.catch((err) => {
if (err.message.includes('nonce')) {
Copy link
Contributor

@jguthrie7 jguthrie7 May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe overkill, but could we be a bit more defensive and check for err.message as well?

Copy link
Contributor Author

@SethMcGuire SethMcGuire May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

err.conclusive = true;
}
reject(err);
});
});
}

Expand Down