SP-1135 Add exports to Node.js SDK #130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swlodarski-sumoheavy
requested changes
Feb 7, 2025
Collaborator
swlodarski-sumoheavy
left a comment
swlodarski-sumoheavy
left a comment
There was a problem hiding this comment.
Additional notes:
- please add export of BitPayException to Exceptions/index.ts
- I think there is a bug here https://github.com/bitpay/nodejs-bitpay-client/blob/6.3.x/src/Model/Ledger/BuyerFields.ts#L14
export class BuyerFields implements BuyerFields {
Please change it to:
export class BuyerFields implements BuyerFieldsInterface {
| import { RateInterface } from './Rates/Rate'; | ||
| import { Rates } from './Rates/Rates'; | ||
| import { Bill, BillInterface } from './Bill/Bill'; | ||
| import { Item as BillItem } from './Bill/Item'; |
Collaborator
There was a problem hiding this comment.
Can you add ItemInterface too?
| import { PayoutGroupFailed, PayoutGroupFailedInterface } from './Payout/PayoutGroupFailed'; | ||
| import { Buyer, BuyerInterface } from './Invoice/Buyer'; | ||
| import { InvoiceBuyerProvidedInfo } from './Invoice/InvoiceBuyerProvidedInfo'; | ||
| import { InvoiceEventTokenInterface } from './Invoice/InvoiceEventToken'; |
Collaborator
There was a problem hiding this comment.
Please add InvoiceEventToken
| import { Rates } from './Rates/Rates'; | ||
| import { Bill, BillInterface } from './Bill/Bill'; | ||
| import { Item as BillItem } from './Bill/Item'; | ||
| import { LedgerInterface } from './Ledger/Ledger'; |
Collaborator
There was a problem hiding this comment.
Please add Ledger
| import { Bill, BillInterface } from './Bill/Bill'; | ||
| import { Item as BillItem } from './Bill/Item'; | ||
| import { LedgerInterface } from './Ledger/Ledger'; | ||
| import { LedgerEntryInterface } from './Ledger/LedgerEntry'; |
Collaborator
There was a problem hiding this comment.
Add LedgerEntry
| import { PayoutRecipient, PayoutRecipientInterface } from './Payout/PayoutRecipient'; | ||
| import { PayoutRecipients, PayoutRecipientsInterface } from './Payout/PayoutRecipients'; | ||
| import { Payout, PayoutInterface } from './Payout/Payout'; | ||
| import { PayoutGroupInterface } from './Payout/PayoutGroup'; |
Collaborator
There was a problem hiding this comment.
Missing PayoutGroup
| import { SupportedTransactionCurrency } from './Invoice/SupportedTransactionCurrency'; | ||
| import { InvoiceDataInterface, InvoiceData } from './Settlement/InvoiceData'; | ||
| import { PayoutInfoInterface, PayoutInfo } from './Settlement/PayoutInfo'; | ||
| import { RefundInfoInterface } from './Settlement/RefundInfo'; |
Collaborator
There was a problem hiding this comment.
Add RefundInfo
Collaborator
There was a problem hiding this comment.
Can you add exports for enum like consts? For example:
import * as InvoiceStatus from './Invoice/InvoiceStatus';
...
export {
...
InvoiceStatus
...
}
This should be done in the following cases:
- Model/Bill/BillStatus.ts
- Model/Invoice/InvoiceStatus.ts
- Model/Invoice/RefundParams.ts
- Model/Invoice/RefundStatus.ts
- Model/Payout/PayoutStatus.ts
- Model/Payout/RecipientReferenceMethod.ts
- Model/Payout/RecipientStatus.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.