Use a better condition message for pendingFailoverAckExists.

This is required because converting `unack` to string will be always something
else and cluster is updated.

Author: AMecea

pkg/mysqlcluster/orc_reconciliation.go

@@ -125,8 +125,9 @@ func (f *cFactory) updateStatusForRecoveries(recoveries []orc.TopologyRecovery)
 	}
 
 	if len(unack) > 0 {
+		msg := getRecoveryTextMsg(unack)
 		f.cluster.UpdateStatusCondition(api.ClusterConditionFailoverAck,
-			core.ConditionTrue, "pendingFailoverAckExists", fmt.Sprintf("%v", unack))
+			core.ConditionTrue, "pendingFailoverAckExists", msg)
 	} else {
 		f.cluster.UpdateStatusCondition(api.ClusterConditionFailoverAck,
 			core.ConditionFalse, "noPendingFailoverAckExists", "no pending ack")
@@ -147,6 +148,7 @@ func (f *cFactory) registerNodesInOrc() error {
 }
 
 func (f *cFactory) getRecoveriesToAck(recoveries []orc.TopologyRecovery) (toAck []orc.TopologyRecovery) {
+	// TODO: check for recoveries that need acknowledge, by excluding already acked recoveries
 	if len(recoveries) == 0 {
 		return
 	}

pkg/mysqlcluster/utils.go

@@ -31,6 +31,7 @@ import (
 	"k8s.io/client-go/tools/reference"
 
 	api "github.com/presslabs/mysql-operator/pkg/apis/mysql/v1alpha1"
+	orc "github.com/presslabs/mysql-operator/pkg/util/orchestrator"
 )
 
 func ensureProbe(in *core.Probe, ids, ts, ps int32, handler core.Handler) *core.Probe {
@@ -186,3 +187,14 @@ func (f *cFactory) getMasterHost() string {
 
 	return masterHost
 }
+
+// getRecoveryTextMsg returns a string human readable for cluster recoveries
+func getRecoveryTextMsg(acks []orc.TopologyRecovery) string {
+	text := ""
+	for _, a := range acks {
+		text += fmt.Sprintf(" {id: %d, uid: %s, success: %t, time: %s}",
+			a.Id, a.UID, a.IsSuccessful, a.RecoveryStartTimestamp)
+	}
+
+	return fmt.Sprintf("[%s]", text)
+}