[BE-1876] Integrate nixpkgs plugin

integrationtests/toolprovider/mise/install_nixpkgs_ruby_test.go

@@ -0,0 +1,46 @@
+//go:build linux_and_mac
+// +build linux_and_mac
+
+package mise
+
+import (
+	"testing"
+
+	"github.com/bitrise-io/bitrise/v2/toolprovider/mise"
+	"github.com/bitrise-io/bitrise/v2/toolprovider/provider"
+	"github.com/stretchr/testify/require"
+)
+
+func TestMiseInstallNixpkgsRuby(t *testing.T) {
+	tests := []struct {
+		name               string
+		requestedVersion   string
+		resolutionStrategy provider.ResolutionStrategy
+		expectedVersion    string
+	}{
+		{"Install specific version", "3.3.9", provider.ResolutionStrategyStrict, "3.3.9"},
+	}
+
+	for _, tt := range tests {
+		miseInstallDir := t.TempDir()
+		miseDataDir := t.TempDir()
+		miseProvider, err := mise.NewToolProvider(miseInstallDir, miseDataDir)
+		require.NoError(t, err)
+
+		err = miseProvider.Bootstrap()
+		require.NoError(t, err)
+
+		t.Run(tt.name, func(t *testing.T) {
+			request := provider.ToolRequest{
+				ToolName:           "ruby",
+				UnparsedVersion:    tt.requestedVersion,
+				ResolutionStrategy: tt.resolutionStrategy,
+			}
+			result, err := miseProvider.InstallTool(request)
+			require.NoError(t, err)
+			require.Equal(t, provider.ToolID("nixpkgs:ruby"), result.ToolName)
+			require.Equal(t, tt.expectedVersion, result.ConcreteVersion)
+			require.False(t, result.IsAlreadyInstalled)
+		})
+	}
+}

toolprovider/asdf/install_plugin.go

@@ -46,7 +46,7 @@ func (a *AsdfToolProvider) InstallPlugin(tool provider.ToolRequest) error {
 		log.Warnf("Failed to check if plugin is already installed: %v", err)
 	}
 	if installed {
-		log.Debugf("Tool plugin %s is already installed, skipping installation.", tool.ToolName)
+		log.Debugf("[TOOLPROVIDER] Tool plugin %s is already installed, skipping installation.", tool.ToolName)
 		return nil
 	}
 

toolprovider/mise/install.go

@@ -9,7 +9,12 @@ import (
 )
 
 func (m *MiseToolProvider) installToolVersion(tool provider.ToolRequest) error {
-	versionString, err := miseVersionString(tool, m.resolveToLatestInstalled)
+	backend := ""
+	if useNixPkgs(tool) {
+		backend = nixpkgsPluginLinkName
+	}
+
+	versionString, err := miseVersionString(tool, m.resolveToLatestInstalled, backend)
 	if err != nil {
 		return err
 	}
@@ -29,10 +34,14 @@ func (m *MiseToolProvider) installToolVersion(tool provider.ToolRequest) error {
 // Helper for easier testing.
 // Inputs: tool ID, tool version
 // Returns: latest installed version of the tool, or an error if no matching version is installed
-type latestInstalledResolver func(provider.ToolID, string) (string, error)
+type latestInstalledResolver func(string, string) (string, error)
 
 func isAlreadyInstalled(tool provider.ToolRequest, latestInstalledResolver latestInstalledResolver) (bool, error) {
-	_, err := latestInstalledResolver(tool.ToolName, tool.UnparsedVersion)
+	toolName := string(tool.ToolName)
+	if useNixPkgs(tool) {
+		toolName = nixpkgsPluginLinkName + ":" + toolName
+	}
+	_, err := latestInstalledResolver(toolName, tool.UnparsedVersion)
 	var isAlreadyInstalled bool
 	if err != nil {
 		if errors.Is(err, errNoMatchingVersion) {
@@ -46,7 +55,7 @@ func isAlreadyInstalled(tool provider.ToolRequest, latestInstalledResolver lates
 	return isAlreadyInstalled, nil
 }
 
-func miseVersionString(tool provider.ToolRequest, latestInstalledResolver latestInstalledResolver) (string, error) {
+func miseVersionString(tool provider.ToolRequest, latestInstalledResolver latestInstalledResolver, backend string) (string, error) {
 	var miseVersionString string
 	resolutionStrategy := tool.ResolutionStrategy
 	if tool.UnparsedVersion == "installed" {
@@ -60,7 +69,7 @@ func miseVersionString(tool provider.ToolRequest, latestInstalledResolver latest
 		// https://mise.jdx.dev/configuration.html#scopes
 		miseVersionString = fmt.Sprintf("%s@prefix:%s", tool.ToolName, tool.UnparsedVersion)
 	case provider.ResolutionStrategyLatestInstalled:
-		latestInstalledV, err := latestInstalledResolver(tool.ToolName, tool.UnparsedVersion)
+		latestInstalledV, err := latestInstalledResolver(string(tool.ToolName), tool.UnparsedVersion)
 		if err == nil {
 			miseVersionString = fmt.Sprintf("%s@%s", tool.ToolName, latestInstalledV)
 		} else {
@@ -74,6 +83,12 @@ func miseVersionString(tool provider.ToolRequest, latestInstalledResolver latest
 	default:
 		return "", fmt.Errorf("unknown resolution strategy: %v", tool.ResolutionStrategy)
 	}
+
+	if backend != "" {
+		// https://mise.jdx.dev/configuration.html#backends
+		miseVersionString = fmt.Sprintf("%s:%s", backend, miseVersionString)
+	}
+
 	return miseVersionString, nil
 
 }

toolprovider/mise/install_plugin.go

@@ -44,7 +44,7 @@ func (m *MiseToolProvider) InstallPlugin(tool provider.ToolRequest) error {
 	}
 	if plugin == nil {
 		// No plugin installation needed (either core tool or registry tool).
-		log.Debugf("No plugin installation needed for tool %s", tool.ToolName)
+		log.Debugf("[TOOLPROVIDER] No plugin installation needed for tool %s", tool.ToolName)
 		return nil
 	}
 
@@ -53,7 +53,7 @@ func (m *MiseToolProvider) InstallPlugin(tool provider.ToolRequest) error {
 		log.Warnf("Failed to check if plugin is already installed: %v", err)
 	}
 	if installed {
-		log.Debugf("Tool plugin %s is already installed, skipping installation.", tool.ToolName)
+		log.Debugf("[TOOLPROVIDER] Tool plugin %s is already installed, skipping installation.", tool.ToolName)
 		return nil
 	}
 

toolprovider/mise/install_test.go

@@ -13,6 +13,7 @@ func TestMiseVersionString(t *testing.T) {
 	tests := []struct {
 		name    string
 		tool    provider.ToolRequest
+		backend string
 		want    string
 		wantErr bool
 	}{
@@ -23,6 +24,7 @@ func TestMiseVersionString(t *testing.T) {
 				UnparsedVersion:    "18.20.0",
 				ResolutionStrategy: provider.ResolutionStrategyStrict,
 			},
+			backend: "",
 			want:    "[email protected]",
 			wantErr: false,
 		},
@@ -33,6 +35,7 @@ func TestMiseVersionString(t *testing.T) {
 				UnparsedVersion:    "3.11",
 				ResolutionStrategy: provider.ResolutionStrategyLatestReleased,
 			},
+			backend: "",
 			want:    "python@prefix:3.11",
 			wantErr: false,
 		},
@@ -43,6 +46,7 @@ func TestMiseVersionString(t *testing.T) {
 				UnparsedVersion:    "1.21",
 				ResolutionStrategy: provider.ResolutionStrategyLatestInstalled,
 			},
+			backend: "",
 			want:    "[email protected]",
 			wantErr: false,
 		},
@@ -53,6 +57,7 @@ func TestMiseVersionString(t *testing.T) {
 				UnparsedVersion:    "17",
 				ResolutionStrategy: provider.ResolutionStrategyLatestInstalled,
 			},
+			backend: "",
 			want:    "java@prefix:17",
 			wantErr: false,
 		},
@@ -63,6 +68,7 @@ func TestMiseVersionString(t *testing.T) {
 				UnparsedVersion:    "3.0",
 				ResolutionStrategy: provider.ResolutionStrategyLatestInstalled,
 			},
+			backend: "",
 			want:    "",
 			wantErr: true,
 		},
@@ -73,14 +79,37 @@ func TestMiseVersionString(t *testing.T) {
 				UnparsedVersion:    "18.0.0",
 				ResolutionStrategy: provider.ResolutionStrategy(999),
 			},
+			backend: "",
 			want:    "",
 			wantErr: true,
 		},
+		{
+			name: "strict resolution with nixpkgs backend",
+			tool: provider.ToolRequest{
+				ToolName:           "ruby",
+				UnparsedVersion:    "3.3.0",
+				ResolutionStrategy: provider.ResolutionStrategyStrict,
+			},
+			backend: "nixpkgs",
+			want:    "nixpkgs:[email protected]",
+			wantErr: false,
+		},
+		{
+			name: "latest released with nixpkgs backend",
+			tool: provider.ToolRequest{
+				ToolName:           "ruby",
+				UnparsedVersion:    "3.3",
+				ResolutionStrategy: provider.ResolutionStrategyLatestReleased,
+			},
+			backend: "nixpkgs",
+			want:    "nixpkgs:ruby@prefix:3.3",
+			wantErr: false,
+		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			latestInstalledResolver := func(toolName provider.ToolID, version string) (string, error) {
+			latestInstalledResolver := func(toolName, version string) (string, error) {
 				// Setup fake behavior based on test case
 				switch tt.tool.ToolName {
 				case "go":
@@ -96,7 +125,7 @@ func TestMiseVersionString(t *testing.T) {
 				return "", fmt.Errorf("no fake behavior defined for tool %s", toolName)
 			}
 
-			got, err := miseVersionString(tt.tool, latestInstalledResolver)
+			got, err := miseVersionString(tt.tool, latestInstalledResolver, tt.backend)
 
 			if tt.wantErr {
 				require.Error(t, err)
@@ -151,7 +180,7 @@ func TestIsAlreadyInstalled(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			latestInstalledResolver := func(toolName provider.ToolID, version string) (string, error) {
+			latestInstalledResolver := func(toolName, version string) (string, error) {
 				if tt.latestInstalledError != nil {
 					return "", tt.latestInstalledError
 				}