-
-
Notifications
You must be signed in to change notification settings - Fork 795
ARM runners (faster than cross compilation qemu) #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c7049ca
Update python-package.yml
johnnynunez 853d509
Merge branch 'main' into main
johnnynunez cb357e1
Update python-package.yml
johnnynunez 7244730
Update python-package.yml
johnnynunez 7a606b7
Merge branch 'main' into main
matthewdouglas 10b77ef
Cleanup
matthewdouglas 62c726b
Matrix update
matthewdouglas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,13 +30,15 @@ jobs: | |
| build-shared-libs: | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| os: [ubuntu-latest, macos-latest, windows-latest, ubuntu-22.04-arm] | ||
| arch: [x86_64, aarch64] | ||
| exclude: | ||
| - os: windows-latest # This probably requires arm64 Windows agents | ||
| - os: windows-latest | ||
| arch: aarch64 | ||
| - os: ubuntu-latest # Temporary. Takes too long, not ready yet. | ||
| - os: ubuntu-latest | ||
| arch: aarch64 | ||
| - os: ubuntu-22.04-arm | ||
| arch: x86_64 | ||
| runs-on: ${{ matrix.os }} # One day, we could run them on native agents. Azure supports this now but it's planned only for Q3 2023 for hosted agents | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
@@ -61,22 +63,20 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest] | ||
| os: [ubuntu-latest, windows-latest, ubuntu-22.04-arm] | ||
| arch: [x86_64, aarch64] | ||
| cuda_version: | ||
| ["11.7.1", "11.8.0", "12.0.1", "12.1.1", "12.2.2", "12.3.2", "12.4.1", "12.5.1", "12.6.3", "12.8.0"] | ||
| exclude: | ||
| - os: windows-latest # This probably requires arm64 Windows agents | ||
| - os: windows-latest | ||
| arch: aarch64 | ||
| - os: ubuntu-latest # Temporary. Takes too long, not ready yet. | ||
| - os: ubuntu-latest | ||
| arch: aarch64 | ||
| - os: ubuntu-22.04-arm | ||
| arch: x86_64 | ||
| runs-on: ${{ matrix.os }} # One day, we could run them on native agents. Azure supports this now but it's planned only for Q3 2023 for hosted agents | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| # Linux: We use Docker to build cross platform Cuda (aarch64 is built in emulation) | ||
| - name: Set up Docker multiarch | ||
| if: startsWith(matrix.os, 'ubuntu') | ||
| uses: docker/setup-qemu-action@v3 | ||
| # Windows: We install Cuda on the agent (slow) | ||
| - uses: Jimver/[email protected] | ||
| if: startsWith(matrix.os, 'windows') | ||
|
|
@@ -109,17 +109,19 @@ jobs: | |
| - build-shared-libs-cuda | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| os: [ubuntu-latest, macos-latest, windows-latest, ubuntu-22.04-arm] | ||
| # The specific Python version is irrelevant in this context as we are only packaging non-C extension | ||
| # code. This ensures compatibility across Python versions, including Python 3.8, as compatibility is | ||
| # dictated by the packaged code itself, not the Python version used for packaging. | ||
| python-version: ["3.10"] | ||
| arch: [x86_64, aarch64] | ||
| exclude: | ||
| - os: windows-latest # This probably requires arm64 Windows agents | ||
| - os: windows-latest | ||
| arch: aarch64 | ||
| - os: ubuntu-latest # Temporary. Takes too long, not ready yet. | ||
| - os: ubuntu-latest | ||
| arch: aarch64 | ||
| - os: ubuntu-22.04-arm | ||
| arch: x86_64 | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
@@ -184,7 +186,7 @@ jobs: | |
| - name: Inspect wheels directory after renaming files | ||
| run: ls -alFR wheels/ | ||
| - name: Create release and upload artifacts | ||
| uses: softprops/action-gh-release@v2.0.8 | ||
| uses: softprops/action-gh-release@v2.2.1 | ||
| with: | ||
| files: wheels/*.whl | ||
| prerelease: true | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.