CI: Run tests on PRs, refactor nightly test workflow #1811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
I should note that on at least one run with the GitHub runner it used an Ice Lake chip - Xeon 8370C, so it's not really guaranteed that we will always get the EPYC. Most of the time we seem to get the EPYC though, and if we need to later set up a runner guaranteed to not have AVX512 support we could look into that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new workflow for running some of our tests on PRs. We reuse some of our nightly test workflow, so it is refactored into a callable workflow that we can use for both nightly and PRs.
On PRs we will run a more limited set of tests. E.g. the Windows CPU tests are skipped as they're quite slow. We also will only run two versions of PyTorch (oldest supported and latest stable).
Additionally we will now run Linux x64 CPU tests on both an Ice Lake Xeon (with AVX512 support) and the default GitHub runner (AMD EPYC, Zen3, no AVX512 support).