Add auto center feature to elastic buffers#1183
Open
martijnbastiaan wants to merge 1 commit intomainfrom
Open
Conversation
martijnbastiaan
force-pushed
the
martijn/add-auto-center-eb
branch
from
5f4c3ac to
cc887cb
Compare
hiddemoll
approved these changes
Feb 6, 2026
Contributor
hiddemoll
left a comment
hiddemoll
left a comment
There was a problem hiding this comment.
Nice work. I have 1 comment, but I'll approve it already
In #1135 we employ a "simple" trick to allow ring buffers to be aligned and UGNs to remain valid while clock control is still stabilizing the system. We do all this in software, which critically relies on the software being "quick enough". This is not always the case, as seen in #1168. Although we've more or less fixed the issue by making EB control much faster (#1178), this commit adds the option to entirely offload this responsibility to hardware. Closes #1179
hiddemoll
force-pushed
the
martijn/add-auto-center-eb
branch
from
cc887cb to
3d1c614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What + why
In #1135 we employ a "simple" trick to allow ring buffers to be aligned and UGNs to remain valid while clock control is still stabilizing the system. We do all this in software, which critically relies on the software being "quick enough". This is not always the case, as seen in #1168. Although we've more or less fixed the issue by making EB control much faster (#1178), this commit adds the option to entirely offload this responsibility to hardware.
Dear reviewer
Do you want me to write direct tests for
autoCentertoo (instead of only Rust/integration tests)?AI disclaimer
I used Claude to generate test cases after telling it what I wanted to test.
Closes #1179
TODO
docs/