Merged
Conversation
lmbollen
force-pushed
the
lucas/BiDf-utils
branch
7 times, most recently
from
ec98c93 to
1067c5c
Compare
martijnbastiaan
previously requested changes
Feb 26, 2026
Contributor
|
But looks really good! Sorry for slamming the "changes requested" without saying that. |
lmbollen
force-pushed
the
lucas/BiDf-utils
branch
5 times, most recently
from
9633967 to
9eff541
Compare
lmbollen
force-pushed
the
lucas/BiDf-utils
branch
from
9eff541 to
636acd4
Compare
lmbollen
force-pushed
the
lucas/BiDf-utils
branch
3 times, most recently
from
7046686 to
62eab5f
Compare
hiddemoll
approved these changes
Mar 2, 2026
Contributor
hiddemoll
left a comment
hiddemoll
left a comment
There was a problem hiding this comment.
I see you've applied all change requests from Martijn, and I have no other change requests.
lmbollen
force-pushed
the
lucas/BiDf-utils
branch
from
62eab5f to
c5f9830
Compare
Also fixes strictness of `Simulate (a, b)`
Especially `Enable` is not rigorously supported
A circuit to bypass fifos to achieve 0 latency fifos
lmbollen
force-pushed
the
lucas/BiDf-utils
branch
from
c5f9830 to
72390fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (what did you do)
Add the unmerged clash-lang/clash-protocols#109
BiDfprotocol alongside some useful components.Why (context, issues, etc.)
I believe this will allow us to write cleaner and more rigid components. Examples will be given in with the introduction of the new primitive to address byte arrays over wishbone. If this proves interesting I would like to merge it into
clash-protocols.Dear reviewer (anything you'd like the reviewer to pay close attention to?)
AI disclaimer (heads-up for more than inline autocomplete)