Merged
Conversation
lmbollen
force-pushed
the
lucas/ReqResp-utils
branch
8 times, most recently
from
7f4be84 to
ec98c93
Compare
lmbollen
force-pushed
the
lucas/ReqResp-utils
branch
2 times, most recently
from
075a7bd to
57d554c
Compare
lmbollen
force-pushed
the
lucas/BiDf-utils
branch
3 times, most recently
from
50d07d1 to
7c44f35
Compare
lmbollen
force-pushed
the
lucas/ReqResp-utils
branch
from
57d554c to
88fb06e
Compare
lmbollen
force-pushed
the
lucas/BiDf-utils
branch
3 times, most recently
from
9eff541 to
636acd4
Compare
lmbollen
force-pushed
the
lucas/ReqResp-utils
branch
from
88fb06e to
ce0173b
Compare
lmbollen
force-pushed
the
lucas/BiDf-utils
branch
3 times, most recently
from
7046686 to
62eab5f
Compare
lmbollen
force-pushed
the
lucas/ReqResp-utils
branch
from
ce0173b to
76ca439
Compare
lmbollen
force-pushed
the
lucas/BiDf-utils
branch
2 times, most recently
from
c5f9830 to
72390fc
Compare
lmbollen
force-pushed
the
lucas/ReqResp-utils
branch
from
76ca439 to
e192099
Compare
hiddemoll
approved these changes
Mar 5, 2026
Contributor
hiddemoll
left a comment
hiddemoll
left a comment
There was a problem hiding this comment.
I've copied some of Martijns comments on the original PR and added a few of my own. All are related to documentation or import grouping. Other than those I'm fine with merging this, so I'll approve in advance.
lmbollen
force-pushed
the
lucas/ReqResp-utils
branch
from
e192099 to
0496b73
Compare
lmbollen
force-pushed
the
lucas/ReqResp-utils
branch
from
0496b73 to
92729b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (what did you do)
Add the unmerged clash-lang/clash-protocols#83
ReqRespprotocol alongside some useful components.Why (context, issues, etc.)
I believe this will allow us to write cleaner and more rigid components. Examples will be given in with the introduction of the new primitive to address byte arrays over wishbone. If this proves interesting I would like to merge it into
clash-protocols.Dear reviewer (anything you'd like the reviewer to pay close attention to?)
AI disclaimer (heads-up for more than inline autocomplete)