feat: add complexipy debris topic #115
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for cleaning up complexipy cache files to the pyclean debris removal feature. Complexipy is a Python code complexity analyzer that creates a .complexipy_cache/ directory, which this change enables pyclean to detect and remove.
Key changes:
- Added 'complexipy' as a new optional debris topic alongside existing tools like mypy, jupyter, and tox
- Updated CLI help text and tests to reflect the new option
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyclean/debris.py | Adds complexipy patterns to DEBRIS_TOPICS dictionary to enable cleaning .complexipy_cache/ directories |
| pyclean/cli.py | Adds 'complexipy' to the optional debris topics list for CLI argument parsing |
| tests/test_cli.py | Updates help text assertion and test expectations to include complexipy in the debris options |
| tests/test_debris.py | Adds complexipy to parametrized tests to ensure cleanup functionality works correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bittner
left a comment
bittner
left a comment
There was a problem hiding this comment.
Copilot found a few nitpicks, and it's right about it!
Please, fix those stylistics issues and add Complexipy to the list of optional debris topics in the README.
Also, please rebase your feature branch atop main. I removed Codacy from the GHA setup, it's a great nuisance. This will make the test jobs succeed in the pipeline.
jakob1379
force-pushed
the
feat/complexipy
branch
2 times, most recently
from
f599d73 to
ff2d3dd
Compare
bittner
left a comment
bittner
left a comment
There was a problem hiding this comment.
Perfect! This looks good now.
The only thing missing is to add Complexipy to the list of optional debris topics in the README. Can you do that?
I'll go ahead and merge the PR, afterwards.
jakob1379
force-pushed
the
feat/complexipy
branch
from
ff2d3dd to
aea6bbc
Compare
bittner
left a comment
bittner
left a comment
There was a problem hiding this comment.
Sorry for nit-picking. Python is a proper noun in this case.
Co-authored-by: Peter Bittner <[email protected]>
|
no need to be sorry, I really appreciate you taking care of this! :D On that note adding codespell etc to the pre-commits might help remove a lot of these small annoyances :) |
|
Thank you for your contribution! 🥇 The feature is included in version 3.5.0, which was released a moment ago. Enjoy! 🍾 |
2 participants
closes:
#114
adds complexipy to depris
tests pass