Draft
Conversation
Introduces crates/bw-remote-uniffi, a UniFFI-based wrapper around the Rust protocol stack that generates bindings for Python, Kotlin, Swift, Ruby, and C# from a single crate using proc-macros (no UDL files). API surface: - RemoteAccessClient object (construct, connect, request_credential, list_sessions, is_ready, close) - RemoteCredentialData and SessionInfo records - RemoteAccessError enum (6 FFI-friendly categories mapped from 18+ internal error variants) - connect_and_request top-level convenience function Includes uniffi-bindgen binary for generating language bindings, Python example in examples/uniffi/, and full test coverage (21 unit tests + 5 integration tests with real proxy server).
- Return error on mutex poison in connect() instead of silently dropping the connected client - Increase event channel buffer from 32 to 256 to prevent potential deadlock (events are not consumed in headless mode) - Remove unused event_rx field from RemoteAccessClient - Implement Drop to auto-close connection if caller forgets close() - Add double-connect integration test verifying second connect replaces the first cleanly
|
Great job! No new security vulnerabilities introduced in this pull request |
- README.md with setup instructions, usage examples, and multi-language binding generation commands - test.py interactive script with CLI args (--token, --domain, --identity) - .gitignore to exclude generated bindings and native library artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
This PR adds a intial spaghetti on the wall uniffi bridge for language like:
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes