Skip to content

Update SDK to 1.0.0-2681-1a956d45 #5756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 22, 2025
Merged

Update SDK to 1.0.0-2681-1a956d45 #5756

merged 10 commits into from
Aug 22, 2025

Conversation

bw-ghapp[bot]
Copy link
Contributor

@bw-ghapp bw-ghapp bot commented Aug 20, 2025 •
edited by jira bot
Loading

Updates the SDK version from 1.0.0-2450-9fe3aeda to com.bitwarden:sdk-android 1.0.0-2681-1a956d45

What's Changed

Raw changelog 
- [PM-24243] Add load_flags method to wasm PlatformClient (#369)
- [PM-22256] Add type and default_user_collection_email to collection (#371)
- [no ticket] Fix wasm being imported on UNIFFI builds (#385)
- SRE-2330 cleanup references to auth-email (#286)
- [deps]: Update typescript to v5.9.2 (#394)
- Update wasm to use the same method as mobile for feature flags (#378)
- [deps]: Update Rust to v2025-08-18 (#271)
- PM-23639: Add CXF Import mappings (#361)
- Update swagger instructions (#398)
- [deps]: Update Rust crate schemars to >=0.8.9, <0.10 (#324)

@bw-ghapp bw-ghapp bot added the automated-pr PR created by workflow or other automation label Aug 20, 2025
@bw-ghapp bw-ghapp bot requested a review from brian-livefront as a code owner August 20, 2025 13:53
@bw-ghapp bw-ghapp bot added the t:ci Updates to automated workflows label Aug 20, 2025
@bw-ghapp bw-ghapp bot requested review from david-livefront and a team as code owners August 20, 2025 13:53
@bw-ghapp bw-ghapp bot added automated-pr PR created by workflow or other automation t:ci Updates to automated workflows labels Aug 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 329f658c-fb4c-465f-ad16-3a43e35c82f7

Great job! No new security vulnerabilities introduced in this pull request

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.84%. Comparing base (bc7e682) to head (a466a0c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lt/repository/util/VaultSdkCollectionExtensions.kt 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5756   +/-   ##
=======================================
  Coverage   83.84%   83.84%           
=======================================
  Files         692      692           
  Lines       52992    53005   +13     
  Branches     7308     7309    +1     
=======================================
+ Hits        44431    44442   +11     
- Misses       5993     5994    +1     
- Partials     2568     2569    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

SaintPatrck
SaintPatrck reviewed Aug 20, 2025
View reviewed changes
app/schemas/com.x8bit.bitwarden.data.vault.datasource.disk.database.VaultDatabase/7.json Outdated
@@ -2,7 +2,7 @@
"formatVersion": 1,
"database": {
"version": 7,
"identityHash": "4c6ad1f5268d7e8add7407201788aa2e",
"identityHash": "11387825dab701f9d2dd2e940ffbd794",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file need to be reverted, and the database version needs to be incremented to prevent this scheme from being regenerated.

SaintPatrck
SaintPatrck reviewed Aug 20, 2025
View reviewed changes
...c/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCollectionExtensions.kt Outdated
Comment on lines 22 to 23
defaultUserCollectionEmail = null,
type = CollectionType.SHARED_COLLECTION,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this.defaultUserCollectionEmail and this.type be passed through, or are we using hard-coded values for a reason?

@vvolkgang vvolkgang mentioned this pull request Aug 21, 2025
Merged
david-livefront
david-livefront reviewed Aug 22, 2025
View reviewed changes
...st/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCollectionExtensionsTest.kt Outdated
import com.bitwarden.network.model.SyncResponseJson
import com.x8bit.bitwarden.data.vault.datasource.sdk.model.createMockCollectionView
import org.junit.Assert
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop this, we alreade import import org.junit.jupiter.api.Assertions.assertEquals a few lines down

david-livefront
david-livefront reviewed Aug 22, 2025
View reviewed changes
app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CollectionViewUtil.kt
fun createMockCollectionView(
number: Int,
name: String? = null,
readOnly: Boolean = false,
manage: Boolean = true,
hidePasswords: Boolean = false,
type: CollectionType = CollectionType.SHARED_COLLECTION,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Patrick had left a comment about this earlier, but doe we want to use DEFAULT_USER_COLLECTION as the defaults?

Copy link
Member

@LRNcardozoWDF LRNcardozoWDF Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use as default CollectionType.SHARED_COLLECTION, that's what the AC team shared with us.

@LRNcardozoWDF LRNcardozoWDF added this pull request to the merge queue Aug 22, 2025
Merged via the queue into main with commit 99ab224 Aug 22, 2025
9 checks passed
@LRNcardozoWDF LRNcardozoWDF deleted the sdlc/sdk-update branch August 22, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaintPatrck SaintPatrck SaintPatrck left review comments

@LRNcardozoWDF LRNcardozoWDF LRNcardozoWDF left review comments

@david-livefront david-livefront david-livefront approved these changes

@brian-livefront brian-livefront Awaiting requested review from brian-livefront brian-livefront is a code owner

Assignees
No one assigned
Labels
automated-pr PR created by workflow or other automation t:ci Updates to automated workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaintPatrck @LRNcardozoWDF @david-livefront