[PM-13374] Update all SDK uuids #14962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hinton
commented
May 27, 2025
Comment on lines
+103
to
+106
| id: "id" as any, | ||
| organizationId: "orgId" as any, | ||
| folderId: "folderId" as any, | ||
| collectionIds: ["collectionId" as any], |
There was a problem hiding this comment.
These should probably be actual UUIDs.
|
Fixed Issues (53)Great job! The following issues were fixed in this Pull Request
|
# Conflicts: # libs/common/src/platform/services/sdk/default-sdk.service.ts
|
|
Opening this for review in since we'd want an initial pass before merging the SDK change. |
coroiu
reviewed
Jun 10, 2025
|
Yes, the tests will work after we bump the sdk version |
# Conflicts: # libs/common/src/platform/services/sdk/default-sdk.service.ts # libs/common/src/vault/models/domain/cipher.ts # libs/common/src/vault/models/view/cipher.view.ts
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14962 +/- ##
==========================================
- Coverage 36.92% 36.92% -0.01%
==========================================
Files 3170 3170
Lines 92167 92181 +14
Branches 13818 13820 +2
==========================================
+ Hits 34037 34040 +3
- Misses 56749 56760 +11
Partials 1381 1381 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dani-garcia
approved these changes
Aug 22, 2025
BTreston
approved these changes
Aug 26, 2025
gbubemismith
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
bitwarden.atlassian.net/browse/PM-13374
📔 Objective
For when bitwarden/sdk-internal#293 is merged.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes