[PM-5756] Trigger Autofill BIT checks on browser build workflow completion with autofill-affecting file changes #15960
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15960 +/- ##
==========================================
- Coverage 36.78% 36.77% -0.02%
==========================================
Files 3233 3233
Lines 92009 92039 +30
Branches 13796 13793 -3
==========================================
+ Hits 33844 33845 +1
- Misses 56781 56809 +28
- Partials 1384 1385 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
jprusik
force-pushed
the
pm-5756
branch
2 times, most recently
from
7d60c9c to
38c9420
Compare
| workflow_run: | ||
| workflows: ["Build Browser"] | ||
| types: | ||
| - completed |
There was a problem hiding this comment.
While this triggers on PR merge (and other event) build success, it will skip the (final) dispatch step, as the "Get changed files" step will yield no changes.
| - 'apps/browser/src/background/**' | ||
| - 'apps/browser/src/platform/services/browser-script-injector.service.ts' |
There was a problem hiding this comment.
Not all of these locations are owned by @bitwarden/team-autofill-dev, but are included because of their common impact on the owned Autofill experience.
Conversely, not all Autofill ownerships are reflected here as they are not relevant to this testing.
|
Proper permissioning and success of dispatch tested and verified with #15988 |
There was a problem hiding this comment.
Looks great, thank you, @jprusik!
I have one small non-blocking nitpick
.github/CODEOWNERS
Outdated
| @@ -137,6 +137,7 @@ nx.json @bitwarden/team-platform-dev | |||
|
|
|||
| ## Autofill team files ## | |||
| apps/browser/src/autofill @bitwarden/team-autofill-dev | |||
| .github/workflows/test-browser-interactions.yml @bitwarden/team-autofill-dev | |||
There was a problem hiding this comment.
Nit ⛏️ , I would put this at the top or bottom of this section, that will make it easier to read
|
…etion with autofill-affecting file changes (#15960) * trigger Autofill BIT checks on browser build workflow completion and autofill-affecting file changes * further adjustments * hardcode bitwarden owner * remove unneeded origin_repo data in dispatch payload * add ownership for workflow * use actions/create-github-app-token * update CODEOWNERS line with suggestion
🎟️ Tracking
PM-5756
📔 Objective
This workflow listens for the completion of the "Build Browser" workflow. If relevant changes were found on the branch that initiated the build workflow, a workflow event will be dispatched to BIT. Workflows in BIT may then trigger on that event.
Planned usage of this event in BIT includes kicking off the Test-all and Test-all-custom-flags workflows and having those events post comments back to the original PR with success/failure messages (this PR on it's own does not trigger any tests).
corresponding BIT work: bitwarden/browser-interactions-testing#373
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes