-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[PM-24618] Integrate CLI sends with server branch #18106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #18106 +/- ##
==========================================
+ Coverage 42.46% 42.61% +0.15%
==========================================
Files 3637 3637
Lines 105768 105848 +80
Branches 15994 16017 +23
==========================================
+ Hits 44915 45112 +197
+ Misses 58954 58812 -142
- Partials 1899 1924 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcamirault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Claude finished @harr1424's task in 3m 16s —— View job Code Review: PM-24618 Integrate CLI sends with server branchReviewed commit: aa241bf SummaryThis PR adds email-based OTP authentication support to CLI Sends, properly gated behind the Review Status: Approve with Minor SuggestionWhat was reviewed:
Key observations:
Findings:
The changes are feature-flagged, well-tested, and follow established patterns. Previous reviewers have approved.
|
mcamirault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You addressed all my concerns, looks great!
mcamirault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes since last review, still looks good
…l-verification-to-Send-receive merge latest from main
6028cc0 to
c8c7f8b
Compare



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-24618
https://bitwarden.atlassian.net/browse/PM-23109
bitwarden/server#5895
📔 Objective
PM-24618: reveal the functionality related to email based OTP in the CLI's send help output
bw send --helpPM-23109: update models to add an
AuthTypeenum and ensure the process of creating and receiving a send supports storing emails associated with the send to be used for email based OTP authentication and theAuthTypeenum valueUsage of
--emailsoption increateandeditcommands is gated behind a feature flag.💻 Command Output
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes