-
Notifications
You must be signed in to change notification settings - Fork 21
Getting started documentation updates: CLI and EF Core database #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6af3cfe
4fc1e76
c16166f
5b833b6
55fbf30
a5517a7
f9b70ee
916c89c
03bcf33
c7285cc
abc1018
ae8f637
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,9 +52,43 @@ npm run build:oss:watch | |
|
|
||
| </Community> | ||
|
|
||
| By default, this will use the official Bitwarden servers. You can target your local server by using | ||
| the [config command](https://bitwarden.com/help/article/cli/#config). You may need to | ||
| [configure node to use your self-signed certificate](https://bitwarden.com/help/article/cli/#using-self-signed-certificates). | ||
| By default, this will use the official Bitwarden servers. If you need to develop with Server running | ||
| locally, follow the instructions below in Environment setup. | ||
|
|
||
| ## Environment setup | ||
|
|
||
| ### Configure Node to trust development certificates | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ๐จ SUGGESTED: Add context about environment variables Consider adding a brief note about when and where to set these environment variables. Currently, it's not clear:
Example addition: ### Configure Node to trust development certificates
Set one of the following environment variables in your shell before running the CLI to connect to a local server with self-signed certificates:This would help developers understand the timing and scope of these configuration steps. |
||
|
|
||
| A quick way to do this is to give Node access to your system certificates: | ||
|
|
||
| ```bash | ||
| export NODE_USE_SYSTEM_CA=1 | ||
| ``` | ||
|
|
||
| Alternatively, you can add the certificate directly to Node: | ||
|
|
||
| ```bash | ||
| export NODE_EXTRA_CA_CERTS=/path/to/your-certificate.pem | ||
| ``` | ||
lastbestdev marked this conversation as resolved.
Show resolved
Hide resolved
Comment on lines
+60
to
+72
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ๐จ SUGGESTED: Consider reformatting to use numbered instructions for consistency with the project style guide The project style guide specifies: "Use numbered paragraphs for instructions/procedures, starting with action-oriented verbs." Consider changing from the current descriptive format to numbered steps: ### Configure Node to trust development certificates
1. Set Node to use your system certificates:
```bash
export NODE_USE_SYSTEM_CA=1Alternatively, add the certificate directly to Node: export NODE_EXTRA_CA_CERTS=/path/to/your-certificate.pem |
||
|
|
||
| ### Target local Server instance | ||
|
|
||
| If you are running the Bitwarden Web application locally, you only need to set the base server | ||
| location. The web application proxies API requests to your local Server APIs. | ||
|
|
||
| Run the following when you have Web running locally: | ||
|
|
||
| ```bash | ||
lastbestdev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| node build/bw.js config server https://localhost:8080 | ||
| ``` | ||
|
|
||
| Otherwise, you need to set the individual Server API locations as follows: | ||
|
|
||
| ```bash | ||
| node build/bw.js config server \ | ||
| --api http://localhost:4000 \ | ||
| --identity http://localhost:33656 | ||
| ``` | ||
|
|
||
| ## Testing and Debugging | ||
|
|
||
|
|
||
lastbestdev marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐จ SUGGESTED: Clarify section reference
Consider making this reference more explicit:
This makes it easier to understand that "Environment setup" is a specific section heading.