-
Notifications
You must be signed in to change notification settings - Fork 21
Add memory hardening deep-dive #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying contributing-docs with
|
| Latest commit: |
5f847b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6be7d1c6.contributing-docs.pages.dev |
| Branch Preview URL: | https://km-memory-hardening.contributing-docs.pages.dev |
|
Great job! No new security vulnerabilities introduced in this pull request |
|
Claude finished @quexten's task in 1m 17s —— View job Claude finished @quexten's task — Re-review of commit 5f847b0 SummaryReviewed commit: 5f847b0 (previously reviewed: b1285fe) Overall Assessment: Looks good! This re-review covers the new commit "Add links" which adds documentation references to the memory hardening deep-dive. Changes since last review:
Reviewed Changes
FindingsNo issues identified. The new links are valuable additions that help readers explore the underlying implementations and external documentation. This review was generated automatically using Claude Code. |
…ng-docs into km/memory-hardening
coltonhurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quexten this is awesome, thanks for the write-up.
Is it worth linking files or paths to make it easy for new readers to dig into the code?
(Totally optional, I know that we might not want to link to code because the code can be moved and the links break. We could link to PR's / commits instead, though I think linking to live code on main would be nice if we are confident it won't move for a while.)
withinfocus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also support some linking here to relevant codebases which will aid in discovery and automation around the hardening practice.
|
Added links to both the code-bases, and relevant API docs for the OS features. |

🎟️ Tracking
No ticket
📔 Objective
Adds a deep-dive to memory hardening in Bitwarden. Some teams were asking about this, so this seemed like a good central place for discovery, since hardening applies to all clients, and also the SDK, and is not very discoverable next to the code. (We do also document these individually in the code in the relevant sections though).
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes