Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Jan 15, 2026

🎟️ Tracking

No ticket

📔 Objective

Adds a deep-dive to memory hardening in Bitwarden. Some teams were asking about this, so this seemed like a good central place for discovery, since hardening applies to all clients, and also the SDK, and is not very discoverable next to the code. (We do also document these individually in the code in the relevant sections though).

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten requested review from a team and eligrubb and removed request for a team January 15, 2026 13:43
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 15, 2026

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f847b0
Status: ✅  Deploy successful!
Preview URL: https://6be7d1c6.contributing-docs.pages.dev
Branch Preview URL: https://km-memory-hardening.contributing-docs.pages.dev

View logs

@quexten quexten changed the title km/memory hardening Add memory hardening deep-dive Jan 15, 2026
@quexten quexten requested review from Thomas-Avery and removed request for eligrubb January 15, 2026 13:45
@quexten quexten added the ai-review Request a Claude code review label Jan 15, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Logo
Checkmarx One – Scan Summary & Details1f89fed7-f17d-447c-a3ef-60ec9f790e66

Great job! No new security vulnerabilities introduced in this pull request

@claude
Copy link
Contributor

claude bot commented Jan 15, 2026

Claude finished @quexten's task in 1m 17s —— View job


Claude finished @quexten's task — Re-review of commit 5f847b0


Summary

Reviewed commit: 5f847b0 (previously reviewed: b1285fe)

Overall Assessment: Looks good!

This re-review covers the new commit "Add links" which adds documentation references to the memory hardening deep-dive. Changes since last review:

  • Added source code references [1], [2], [3] linking to relevant implementations in sdk-internal and clients repositories
  • Added external documentation links (kernel docs, Microsoft docs, Linux man pages)
  • Added GitHub issue link for the Snap/xdg-desktop-portal limitation

Reviewed Changes

File Description
docs/architecture/deep-dives/memory-hardening.md Added reference links throughout

Findings

No issues identified. The new links are valuable additions that help readers explore the underlying implementations and external documentation.


This review was generated automatically using Claude Code.

@quexten quexten marked this pull request as ready for review January 15, 2026 13:58
@quexten quexten requested review from a team as code owners January 15, 2026 13:58
Copy link
Member

@coltonhurst coltonhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quexten this is awesome, thanks for the write-up.

Is it worth linking files or paths to make it easy for new readers to dig into the code?

(Totally optional, I know that we might not want to link to code because the code can be moved and the links break. We could link to PR's / commits instead, though I think linking to live code on main would be nice if we are confident it won't move for a while.)

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also support some linking here to relevant codebases which will aid in discovery and automation around the hardening practice.

@quexten
Copy link
Contributor Author

quexten commented Jan 19, 2026

Added links to both the code-bases, and relevant API docs for the OS features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants