Split build and release workflows for gui and cli#816
Closed
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
=====================================
Coverage 7.71% 7.71%
=====================================
Files 68 68
Lines 2760 2760
Branches 477 477
=====================================
Hits 213 213
Misses 2532 2532
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job, no security vulnerabilities found in this Pull Request |
Member
Author
|
This would have some downstream consequences we don't want to deal with right now - we have more important things to address in this repo so we may come back to it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A but I'll create a ticket if we accept this proposal
📔 Objective
Split the build and release workflows by client, so that we can build and release CLI and GUI clients separately.
My primary reason here is maintainability - the build workflow is currently 651 LOC with 6 different build jobs for all the combinations of
platform x app, which is hard to keep track of in a yaml file. This change also matches how our monorepo workflows are structured; avoids mixing app-specific setup steps; and would allow for separate releases if required (e.g. if we had a CLI/GUI specific bug we wanted to fix).The downside is some duplication in setup and completion jobs in each workflow, but I think this is minimal. There may also be some process overhead when we do a release which we can discuss as a team.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes