Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 16.01% 16.01%
=======================================
Files 67 67
Lines 2791 2791
Branches 481 481
=======================================
Hits 447 447
Misses 2306 2306
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (3)Checkmarx found the following issues in this Pull Request
|
|
Claude finished @r-tome's task in 4m 14s —— View job Code Review CompleteI've reviewed the dependency updates for @yao-pkg/pkg (v5.16.1 → v6.5.1) and Node.js (v20 → v22). ✅ What's CorrectThe PR correctly implements the required changes per the VULN-251 security vetting:
❌ Critical Issue - Changes RequestedREADME.md line 51 currently states: This must be updated to reflect the new Node.js requirement: Without this change, developers following the README will install the wrong Node version and encounter build failures due to the
|
|
Overall Assessment: REQUEST CHANGES Important Issues:
Additional Questions:
See inline comments for details. |
There was a problem hiding this comment.
This is a special case, so we have some specific requirements around this upgrade:
- We need to upgrade to
yao-pkg/pkg@6.5.1exactly - this package has been vetted at that version. See https://bitwarden.atlassian.net/browse/VULN-251 for more context. - We also need to upgrade to node v22, because that is the version of node that has been vetted in that package. That can be done by updating
.nvmrcin the root of the repo. Also updateenginesinpackage.json. - This determines the node version for CLI, but it's also worth checking the version of node used by Electron - ideally they should match. We're using Electron 39.2.1 which already uses node 22, so no changes required there.
996833c to
3be7420
Compare
|
Keytar does not support node 22 |




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-24898
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes