Conversation
There was a problem hiding this comment.
gsuite is the guinea pig right now.
|
New Issues (6)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
==========================================
+ Coverage 14.90% 18.38% +3.47%
==========================================
Files 67 70 +3
Lines 2791 3014 +223
Branches 481 524 +43
==========================================
+ Hits 416 554 +138
- Misses 2271 2352 +81
- Partials 104 108 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| rootPath: null, | ||
| ad: true, | ||
| username: "admin", | ||
| password: "secret-password", |
Check warning
Code scanning / Checkmarx One
Use Of Hardcoded Password Medium test
| rootPath: null, | ||
| ad: true, | ||
| username: "admin", | ||
| password: "secret-password", |
Check warning
Code scanning / Checkmarx One
Use Of Hardcoded Password Medium test
| rootPath: null, | ||
| ad: true, | ||
| username: "admin", | ||
| password: "secret-password", |
Check warning
Code scanning / Checkmarx One
Use Of Hardcoded Password Medium test
| rootPath: null, | ||
| ad: true, | ||
| username: "admin", | ||
| password: "secret-password", |
Check warning
Code scanning / Checkmarx One
Use Of Hardcoded Password Medium test



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31159?search_id=6e3045c2-dde7-4d70-bc1b-5e47e132604d
📔 Objective
This is the post-account switching, pre-StateProvider StateService, which is a large monolith containing every getter and setter for every piece of data used by all clients. This in turn means that we cannot delete the data models used by StateService, which has a cascading effect of preventing code deletion.
StateService was never very stable, so we should avoid changing this class at all as it is likely to cause regressions. Additionally, Directory Connector never needed account switching, so it is more complex than we need. It should be replaced and existing data migrated if necessary.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes