Skip to content

[PM-12442] Remove substitute dependency#992

Merged
BTreston merged 1 commit intomainfrom
ac/pm-12442-remove-substitute
Feb 10, 2026
Merged

[PM-12442] Remove substitute dependency#992
BTreston merged 1 commit intomainfrom
ac/pm-12442-remove-substitute

Conversation

@BTreston
Copy link
Contributor

@BTreston BTreston commented Feb 5, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12442

📔 Objective

This is an old mocking library that we no longer use and has been replaced with jest-mock-extended.

"@fluffy-spoon/substitute": "1.208.0"

Deletes tests that use this lib and migrates relevant tests to jest-mock-extended

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.90%. Comparing base (28f0ff4) to head (731d41d).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   14.90%   14.90%           
=======================================
  Files          67       67           
  Lines        2791     2791           
  Branches      481      481           
=======================================
  Hits          416      416           
  Misses       2271     2271           
  Partials      104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

@BTreston BTreston marked this pull request as ready for review February 5, 2026 19:12
@BTreston BTreston requested a review from a team as a code owner February 5, 2026 19:12
@BTreston BTreston requested a review from JaredScar February 5, 2026 19:12
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Logo
Checkmarx One – Scan Summary & Details84abf49b-430e-4511-b727-793aabcf94ea

Great job! No new security vulnerabilities introduced in this pull request

@BTreston BTreston merged commit 3059934 into main Feb 10, 2026
26 checks passed
@BTreston BTreston deleted the ac/pm-12442-remove-substitute branch February 10, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants