[BRE-1706] Add simulated branch support to _version.yml#633
Open
brandonbiete wants to merge 2 commits intomainfrom
Open
[BRE-1706] Add simulated branch support to _version.yml#633brandonbiete wants to merge 2 commits intomainfrom
brandonbiete wants to merge 2 commits intomainfrom
Conversation
Add optional sim_branch input to enable testing with simulated branches. When provided, workflow checks out the specified branch and uses its HEAD SHA instead of github.sha for commit lookups. - checkout_ref: Use sim_branch if provided, otherwise current ref - working_sha: Use HEAD SHA from sim_branch if provided, otherwise github.sha - Update Get PR ID step to use working_sha
Use environment variables instead of direct template expansion in shell scripts to prevent potential code injection vulnerabilities.
|
Great job! No new security vulnerabilities introduced in this pull request |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-1706
📔 Objective
Add optional sim_branch input to enable testing with simulated branches. When provided, workflow checks out the specified branch and uses its HEAD SHA instead of github.sha for commit lookups.
🚨 Breaking Changes