Skip to content

[PM-27181] - Grant additional permissions for review code#242

Merged
theMickster merged 1 commit intomainfrom
ai/review-code-permission-update
Nov 13, 2025
Merged

[PM-27181] - Grant additional permissions for review code#242
theMickster merged 1 commit intomainfrom
ai/review-code-permission-update

Conversation

@theMickster
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27181
https://bitwarden.atlassian.net/browse/BRE-1331

📔 Objective

Grant additional permissions for the reusable review workflow to ensure that we can also execute the reusable workflow in private repos.

Order matters when updating because:

  1. If you add a required permission to the reusable workflow definition without callers having it, those workflows will fail
  2. Callers can grant more permissions than the reusable workflow requires without breaking
  3. Reusable workflows cannot grant themselves permissions - they can only use what the caller provides

Further information on proper permissions found below

  1. Reuse Workflow - GitHub
  2. Workflow syntax for GitHub Actions

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@theMickster theMickster requested a review from a team as a code owner November 13, 2025 13:49
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.04%. Comparing base (2118355) to head (00d2d52).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #242   +/-   ##
=====================================
  Coverage   7.04%   7.04%           
=====================================
  Files         49      49           
  Lines       1818    1818           
  Branches      99      99           
=====================================
  Hits         128     128           
  Misses      1685    1685           
  Partials       5       5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theMickster theMickster merged commit 747efc8 into main Nov 13, 2025
13 of 15 checks passed
@theMickster theMickster deleted the ai/review-code-permission-update branch November 13, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants