-
Notifications
You must be signed in to change notification settings - Fork 14
Auth/PM-22661 - Send Access #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…el + send access token struct
Great job! No new security vulnerabilities introduced in this pull request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 72.71% 73.10% +0.38%
==========================================
Files 241 255 +14
Lines 20152 20755 +603
==========================================
+ Hits 14654 15172 +518
- Misses 5498 5583 +85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… locations to be more idiomatic and logical
…flat structures and test utilities wiremock and zeroize.
…ng C dynamic lib, build a normal rust lib (rlib) for this crate since a C dynamic lib can't be used to run E2E tests.
…ion tests can only access the public API
I just took a very quick glance at this PR.
|
…de which was used as example
…cess can access its content but don't re-export (2) Add rest of public exports to token_request module.
…data (2) Rename password_hash to password_hash_b64
…th with required deps and cleanup bw-wasm-internal
…al + add dev deps so we can integration test bw-auth next
…handling conversion logic in place with Andreas' help
…mmit the error conversion logic
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-22661
📔 Objective
To build out the SDK portion of the new
Auth/SendAccess
feature which serves outSendAccessTokens
for successful authN requests.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes