Skip to content

Auth/PM-22661 - Send Access #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 59 commits into
base: main
Choose a base branch
from

Conversation

JaredSnider-Bitwarden
Copy link

@JaredSnider-Bitwarden JaredSnider-Bitwarden commented Jul 17, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22661

📔 Objective

To build out the SDK portion of the new Auth/SendAccess feature which serves out SendAccessTokens for successful authN requests.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 17, 2025

Logo
Checkmarx One – Scan Summary & Details4c466fda-1b43-4720-8e89-430087405002

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 86.44860% with 29 lines in your changes missing coverage. Please review.

Project coverage is 73.10%. Comparing base (812865f) to head (9c57d56).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...sts/enums/send_access_token_payload_credentials.rs 17.64% 14 Missing ⚠️
...uth/send_access/services/send_token_api_service.rs 78.72% 10 Missing ⚠️
...es/bitwarden-wasm-internal/src/auth/auth_client.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   72.71%   73.10%   +0.38%     
==========================================
  Files         241      255      +14     
  Lines       20152    20755     +603     
==========================================
+ Hits        14654    15172     +518     
- Misses       5498     5583      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…flat structures and test utilities wiremock and zeroize.
…ng C dynamic lib, build a normal rust lib (rlib) for this crate since a C dynamic lib can't be used to run E2E tests.
@Hinton
Copy link
Member

Hinton commented Jul 22, 2025

I just took a very quick glance at this PR.

  • When communicating against our own server we can generally use the auto-generated API bindings, https://contributing.bitwarden.com/architecture/sdk/server-bindings.
  • We generally don't want to write code in wasm-internal as that limits it to only web clients. In most cases the logic should be placed in the relevant rust crate and exposed through the Client struct.

…cess can access its content but don't re-export (2) Add rest of public exports to token_request module.
…data (2) Rename password_hash to password_hash_b64
…th with required deps and cleanup bw-wasm-internal
…al + add dev deps so we can integration test bw-auth next
@JaredSnider-Bitwarden JaredSnider-Bitwarden changed the title Auth/PM-22661/send access Auth/PM-22661 - Send Access Aug 5, 2025
Copy link

sonarqubecloud bot commented Aug 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants