PM-23648: All Identities (passport, driving-license, id-doc, name) -> Identity #363
Conversation
| r#type: FieldType::Text as u8, | ||
| linked_id: None, | ||
| }) | ||
| } |
There was a problem hiding this comment.
@Hinton You requested this function in another PR, would it be OK to dissmiss that review and refactor using this method? (will move it in said refactor PR)
|
Great job, no security vulnerabilities found in this Pull Request |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cxf/sample #363 +/- ##
=============================================
Coverage ? 73.99%
=============================================
Files ? 249
Lines ? 21454
Branches ? 0
=============================================
Hits ? 15874
Misses ? 5580
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
@audreyality If there are multiple documents in the CXF import then you'll have multiple identities stored in Bitwarden, one for each. In the future we may tro to de-dupe the incoming data, unless we find it breakes in cases like yours. However, we don't that in this PR so I think we're good? |
🎟️ Tracking
📔 Objective
This PR maps multiple identity documents to Identity + custom fields. PR was submitted in a rush, forgive me if it fails tests but would be worthwhile to have early reviews on my approach.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes