Skip to content

[PM-22256] Add type and default_user_collection_email to collection #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 11, 2025

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Jul 31, 2025

🎟️ Tracking

PM-22256

📔 Objective

This adds type and default user collection email to the Collection struct. Type is only added to CollectionView. Name is now computed by the decrypt function of Collection as it is unneeded on the CollectionView.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jrmccannon jrmccannon requested review from a team as code owners July 31, 2025 16:21
Copy link
Contributor

github-actions bot commented Jul 31, 2025

Logo
Checkmarx One – Scan Summary & Details1e252453-2ed9-4a01-ae76-913218e01fce

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 94.01709% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.22%. Comparing base (ae0cae2) to head (335b573).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-collections/src/collection.rs 93.80% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   73.95%   74.22%   +0.26%     
==========================================
  Files         252      253       +1     
  Lines       21574    21890     +316     
==========================================
+ Hits        15955    16247     +292     
- Misses       5619     5643      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Aug 1, 2025

Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all rust to me 😁 but my feedback has been addressed.

@jrmccannon jrmccannon merged commit bceb681 into main Aug 11, 2025
51 of 52 checks passed
@jrmccannon jrmccannon deleted the jmccannon/ac/pm-22256-collection-type-properties branch August 11, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants