-
Notifications
You must be signed in to change notification settings - Fork 14
[PM-22256] Add type and default_user_collection_email to collection #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-22256] Add type and default_user_collection_email to collection #371
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
==========================================
+ Coverage 73.95% 74.22% +0.26%
==========================================
Files 252 253 +1
Lines 21574 21890 +316
==========================================
+ Hits 15955 16247 +292
- Misses 5619 5643 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all rust to me 😁 but my feedback has been addressed.
🎟️ Tracking
PM-22256
📔 Objective
This adds type and default user collection email to the Collection struct. Type is only added to CollectionView. Name is now computed by the decrypt function of Collection as it is unneeded on the CollectionView.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes