[PM-23653] Add support for ssh keys #375
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 74.11% 74.15% +0.04%
==========================================
Files 253 254 +1
Lines 21774 21879 +105
==========================================
+ Hits 16138 16225 +87
- Misses 5636 5654 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| }; | ||
|
|
||
| let fields = [ | ||
| credential.key_comment.as_ref().map(|comment| Field { |
There was a problem hiding this comment.
Note (non-actionable): In the agent, we treat the name of the cipher as the comment, and advertise it as such. We may want to research (not here) how other clients treat comment vs name, to not disrupt user experience. If someone comes over from another product which uses a separate key comment field, suddenly all their ciphers may be named something different.
There was a problem hiding this comment.
I think we will have a lot of follow up work as other credential managers implements credential exchange and we discover edge cases 😰
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-23653
📔 Objective
Adds support for importing ssh keys using CXF.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes