[SM-1570] Adding new item to organization license to disable SM ads for users

[cd-bitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1740
https://bitwarden.atlassian.net/browse/SM-1742

📔 Objective

Adding the new column to the database for adding a new item to the organization table for "disabling SM ads for users", this new item is called UseDisableSMAdsForUsers.

• SQL updates to the Organization table
• Migration Scripts
• Entity Framework Changes
• Followed advice from Connor Turnbull and these documents : https://bitwarden.atlassian.net/wiki/spaces/EN/pages/2014642217/Adding+a+new+plan+feature, https://bitwarden.atlassian.net/wiki/spaces/EN/pages/2070446163/Technical+Breakdown+Disable+SM+Ads+for+Users

📸 Screenshots

N/A

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 3ad52dc9-f422-4928-b32b-0023d1d179e3

New Issues (3)

Checkmarx found the following issues in this Pull Request

#	Severity	Issue	Source File / Package	Checkmarx Insight
1		CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1511	details Method at line 1511 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... Attack Vector
2		CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1387	details Method at line 1387 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... Attack Vector
3		CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 245	details Method at line 245 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows t... Attack Vector

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/Billing/Controllers/VNext/AccountBillingVNextController.cs: 97

[codecov]

Codecov Report

❌ Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.97%. Comparing base (f2aa742) to head (b8860ca).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...AdminConsole/Views/Shared/_OrganizationForm.cshtml	0.00%	3 Missing ⚠️
...illing/Organizations/Models/OrganizationLicense.cs	40.00%	3 Missing ⚠️
...Admin/AdminConsole/Models/OrganizationEditModel.cs	33.33%	2 Missing ⚠️
...Admin/AdminConsole/Models/OrganizationViewModel.cs	0.00%	1 Missing ⚠️
.../Core/AdminConsole/Services/OrganizationFactory.cs	66.66%	1 Missing ⚠️
...mplementations/OrganizationLicenseClaimsFactory.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6482      +/-   ##
==========================================
+ Coverage   55.03%   58.97%   +3.93%     
==========================================
  Files        1934     1934              
  Lines       85581    85611      +30     
  Branches     7656     7659       +3     
==========================================
+ Hits        47098    50486    +3388     
+ Misses      36695    33256    -3439     
- Partials     1788     1869      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cyprain-okeke]

looks good

[claude]

Claude finished @cd-bitwarden's task in 2m 51s —— View job

---

Code Review Complete

• Starting code review
• Analyzing changes
• Posting review comments

The bitwarden-code-reviewer agent has completed its review and posted inline comments directly on the PR.

[mkincaid-bw]

Additional refresh statements needed, plus a question regarding casing.

[rkac-bw]

LGTM

[rkac-bw]

lgtm