Skip to content

Conversation

@Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Dec 22, 2025

🎟️ Tracking

PM-29650

📔 Objective

update cipherserver softdelete to keep archived date so restored items return to archive.

Note: Ignore restore archive refresh in screen recording. Bug ticket created

📸 Screen Recording

PM-29650-softdelete.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Jingo88 Jingo88 requested a review from a team as a code owner December 22, 2025 18:21
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa1608af2-15b4-4fa6-9027-900d44c072f9

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.68%. Comparing base (69d72c2) to head (5fa9e24).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6771      +/-   ##
==========================================
- Coverage   58.55%   54.68%   -3.87%     
==========================================
  Files        1925     1926       +1     
  Lines       85669    85707      +38     
  Branches     7669     7673       +4     
==========================================
- Hits        50162    46871    -3291     
- Misses      33649    37053    +3404     
+ Partials     1858     1783      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jingo88 Jingo88 merged commit 34b4dc3 into main Dec 29, 2025
45 checks passed
@Jingo88 Jingo88 deleted the PM-29650-keep-archivedate-softdelete branch December 29, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants