Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Dec 27, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29822

📔 Objective

  1. Sends minor dependency updates for all Platform-owned dependencies to the dependency approval dashboard instead of generating PRs for them.
  2. Rearranges the rules into commented sections for team ownership assignment, grouping, and dashboard configuration for easier changes in the future.
  3. Assigns lockFileMaintenance to Platform to avoid it going unowned.

This mirrors the changes in bitwarden/clients#17981 for clients.

📓 Note that we are not sending any AspNetCore or Microsoft.Extensions package updates to the dashboard, as we've decided we want to keep patch and minor updates for these as they tend to have more significant changes in them.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Ignore minor updates for Platform deps Ignore minor updates for Platform deps and assign lockFileMaintenance Dec 27, 2025
@trmartin4 trmartin4 marked this pull request as ready for review December 27, 2025 23:08
@trmartin4 trmartin4 requested review from a team and djsmith85 December 27, 2025 23:08
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailscc04d636-f7f9-49f8-8808-eebb3bb6d979

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.73%. Comparing base (0cfb683) to head (d6528d2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6780      +/-   ##
==========================================
- Coverage   54.73%   54.73%   -0.01%     
==========================================
  Files        1920     1920              
  Lines       85227    85227              
  Branches     7628     7628              
==========================================
- Hits        46646    46645       -1     
- Misses      36806    36807       +1     
  Partials     1775     1775              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trmartin4 trmartin4 merged commit bf5cacd into main Dec 28, 2025
48 checks passed
@trmartin4 trmartin4 deleted the platform/update-dependency-minor-handling branch December 28, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants