Skip to content

Conversation

maxkpower
Copy link
Contributor

🎟️ Tracking

n/a

📔 Objective

Adds two new optional fields to BitwardenSecret:

  • projectIds: Filter secrets to specific projects
  • useKeyMapping: Automatically use keys instead of UUIDs

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@maxkpower maxkpower requested a review from a team as a code owner October 20, 2025 17:32
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 29.23077% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.44%. Comparing base (76a7b06) to head (33342ca).

Files with missing lines Patch % Lines
internal/controller/bitwardensecret_controller.go 31.66% 38 Missing and 3 partials ⚠️
api/v1/zz_generated.deepcopy.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   63.37%   61.44%   -1.94%     
==========================================
  Files          11       11              
  Lines        1166     1219      +53     
==========================================
+ Hits          739      749      +10     
- Misses        408      447      +39     
- Partials       19       23       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa5ad2cfa-3944-4a88-8507-4a75784ca1fd

Great job! No new security vulnerabilities introduced in this pull request

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-27165
Link: https://bitwarden.atlassian.net/browse/PM-27165

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title use keys instead of UUIDs [PM-27165] use keys instead of UUIDs Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants