Skip to content

Conversation

evanjarrett
Copy link

🎟️ Tracking

#47
#94

📔 Objective

This implements an optional parameter namespace in AuthToken that allows for fetching the token from an external namespace than the one the BitwardenSecret is currently in.

In addition to this, I have made small changes to the GitHub Actions workflows so that they build, or are appropriately skipped on forked branches.
One of those was caused by adding the default permissions to the workflow as read. We need the GITHUB_SECRET to have write permissions in order to publish new packages to the org.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@evanjarrett evanjarrett requested a review from a team as a code owner July 6, 2025 01:32
@evanjarrett evanjarrett requested a review from aj-bw July 6, 2025 01:32
@CLAassistant
Copy link

CLAassistant commented Jul 6, 2025

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-23410
Link: https://bitwarden.atlassian.net/browse/PM-23410

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title Feature: Allow loading auth tokens from external namespace [PM-23410] Feature: Allow loading auth tokens from external namespace Jul 6, 2025
@JackHull
Copy link

JackHull commented Aug 5, 2025

Any update on this? This feature is trivial for a clean & scalable setup. Replicating the secret for every namespace is hugely anti-pattern and insecure.

@segidev
Copy link

segidev commented Aug 5, 2025

Any update on this? This feature is trivial for a clean & scalable setup. Replicating the secret for every namespace is hugely anti-pattern and insecure.

I switched to External Secrets until this is implemented and stable. It works fantastic with External Secrets.

@aj-bw aj-bw requested a review from a team August 7, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants