Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Nov 18, 2025

The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.

You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.

🔕 Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.

❓ Got questions? Does something look wrong to you? Please don't hesitate to request help here.


This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner November 18, 2025 15:58
@renovate renovate bot requested a review from pixman20 November 18, 2025 15:58
@renovate renovate bot mentioned this pull request Nov 18, 2025
8 tasks
@bitwarden-bot bitwarden-bot changed the title [deps]: migrate Renovate config [PM-28384] [deps]: migrate Renovate config Nov 18, 2025
@bitwarden-bot
Copy link

Internal tracking:

@renovate renovate bot changed the title [PM-28384] [deps]: migrate Renovate config [deps]: migrate Renovate config Nov 19, 2025
@pixman20
Copy link
Contributor

@claude review this

@claude
Copy link

claude bot commented Nov 19, 2025

Claude finished @pixman20's task —— View job


Code Review: Renovate Configuration Migration

Summary: This PR contains an automated Renovate configuration migration that updates deprecated field names to their current equivalents. The changes are purely cosmetic and formatting-related - no functional behavior is changed.


Changes Analysis

What Changed

The diff shows two types of changes in .github/renovate.json:

  1. Formatting Changes (Lines 3-44): All arrays are now formatted with each element on a separate line instead of inline. This is purely a style/readability improvement.

  2. Field Rename (Lines 47-50): The key migration is:

    • Old: "fileMatch": ["^actionlint_version\\.yaml$"]
    • New: "managerFilePatterns": ["/^actionlint_version\\.yaml$/"]

Why This Migration Matters

According to the Renovate documentation, fileMatch has been deprecated in favor of managerFilePatterns for custom managers. The new field:

  • Uses the same regex pattern but wrapped in forward slashes (/pattern/)
  • Is the officially supported field name going forward
  • Prevents future compatibility issues when fileMatch is fully removed

Review Findings

Approved Changes

  1. Field Migration is Correct: The fileMatchmanagerFilePatterns rename is the correct migration path for Renovate's custom managers
  2. Pattern Preserved: The regex pattern ^actionlint_version\\.yaml$ is correctly preserved and now properly wrapped in slashes
  3. No Functional Impact: All existing functionality remains identical - this is a configuration schema update only
  4. Formatting Improvements: Multi-line array formatting improves readability

📝 Observations

  1. Cosmetic Changes Dominate: 35 additions / 10 deletions, but most are just formatting (whitespace/newlines)
  2. Standard Renovate Migration: This is a typical automated migration that Renovate performs to keep configs up-to-date
  3. Future-Proofing: Merging this prevents potential issues when deprecated fields are removed

Recommendation

✅ LGTM - Safe to Merge

This is a standard, low-risk configuration migration that:

  • Updates deprecated field names to current standards
  • Improves readability with better formatting
  • Has zero functional impact on Renovate's behavior
  • Aligns with Renovate's current best practices

As noted in the PR description, while Renovate will continue to migrate these fields internally, it's good practice to merge this to prevent future issues when migrations are eventually removed.


Additional Context

Given this is the Bitwarden Workflow Linter repository (which publishes rules organization-wide), keeping dependencies and tooling configurations up-to-date is especially important. However, this particular change only affects how Renovate itself runs in this repository - it does not impact the linting rules distributed to other Bitwarden repositories.


pixman20
pixman20 previously approved these changes Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants