Arturia keylab track select logic and cosmetic improvements #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening the PR to fix Keylab MK2 track select buttons @abique
The Bank button on Keylab changes the MIDI notes emitted by Next and Previous buttons. Previously Bitwig extension did nothing when Bank is enabled. According to Arturia manual if the Bank button is enabled then Next and Previous should scroll by 8 tracks (and scroll by 1 track if Bank is disabled). Added this behavior. Switched the meaning of the buttons so that Previous button goes down the track list and Next button goes up.
That is much more intuitive to use since Previous button is on the bottom and it feels like "down". The Bitwig manual for Keylab MKII doesn't specify exactly what these buttons do besides scroll tracks. Please reverse if it's wrong, but it handles simpler for me.
Added a pulsing light (GREY to track color) for the currently selected track button for better visual feedback