Fixes #26 recursive cend() with line from above

[ckormanyos]

Checklist

• [x ] I have read the CONTRIBUTING guidelines
• [x ] The coding style is consistent with the rest of the library
• [x ] My branch's history is clean and coherent. This could be done through
  at least one of the following practices:
  • Rebasing my branch off of the branch being merged to
  • Squashing commits to create a more cohesive history
• [x ] If relevant, I have included unit-tests (for new code/bugfixes)

---

Description

GitHub Issues

[ckormanyos]

Hi @bitwizeshift I've PR'ed this simple fix of the recursive call expressed in #26.

I have not looked at your CI, but some of those runners will (if they are the default on GHA) be long deprecated.

Cc: @arjunae

[bitwizeshift]

Hi @bitwizeshift I've PR'ed this simple fix of the recursive call expressed in #26.

I have not looked at your CI, but some of those runners will (if they are the default on GHA) be long deprecated.

Cc: @arjunae

Thanks for the contribution!

Yep, these are very deprecated -- but I'm not entirely surprised. I always meant to convert these to docker containers, just never got around to it.

[bitwizeshift]

Bypassed checks because of failing runners. Thanks again!

[ckormanyos]

but I'm not entirely surprised. I always meant to convert these to docker containers, just never got around to it.

Indeed, yours is an interesting case. At first, I thought (naively) hey, update to latest whatever.

But that would not be right. The whole point of the Backport is to NOT use stuff like ubuntu-latest or windows-latest or macos-latest. This is because you are specifically targeting old compilers.

At Boost where I work also, we have a bunch of containers that have stuff back to the era of GCC-5. But I'm not really responsible of the containers in the projects where I work.

[ckormanyos]

Thanks @bitwizeshift and @arjunae

[bitwizeshift]

@ckormanyos

But that would not be right. The whole point of the Backport is to NOT use stuff like ubuntu-latest or windows-latest or macos-latest. This is because you are specifically targeting old compilers.

Yeah, that's exactly the problem.

That said: I have a lot more CI experience nowadays; certainly much more than I did when I started this project, so this is actually something that I should try getting to. GitHub supports using docker container images as the base runner image -- so in theory I should be able to use some of gcc and clang containers for that. The only thing I would need to do is install cmake in those containers. Of course, this will only work for Linux. MacOS and Windows I'd suspect shouldn't matter as much.

I just haven't done C++ in ages, so this project (and my other C++ projects) have fallen on the back-burner. I'll try to get around to this this weekend.