Merged
Conversation
bjorn3
reviewed
Oct 21, 2025
src/wasi.ts
Outdated
| this.fds.splice(fd, this.fds.length - fd); | ||
| break; | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
A single WASI instance shouldn't be reused across multiple .start() calls, so this can close all fds. This should still call fd_close on individual fds though, they may want a custom cleanup.
I'm a bit concerned about breaking existing users that may be reusing WASI across multiple .start() calls though. Maybe moving this commit to a separate PR that could be merged for a future v0.3 release would be a solution?
Contributor
Author
There was a problem hiding this comment.
Fair. I've removed the commit and will open a follow-up one after this one lands.
bjorn3
reviewed
Oct 21, 2025
TerrorJack
force-pushed
the
fix-fds-leak
branch
from
32894bb to
fe02e8f
Compare
bjorn3
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97, implement free-list allocation for wasi fds, and auto-close non-preopen fds after starting a wasip1 command module.